Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Update Vesting Balances to Table Style #2979

Closed
startailcoon opened this issue Jul 24, 2019 · 4 comments · Fixed by #3014
Closed

[3] Update Vesting Balances to Table Style #2979

startailcoon opened this issue Jul 24, 2019 · 4 comments · Fixed by #3014
Assignees
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Milestone

Comments

@startailcoon
Copy link
Contributor

startailcoon commented Jul 24, 2019

Today we have the vesting balances in a uncomfortable list, mainly because it wasn't used by others than witnesses and workers, while LTM had usually just one object, their normal vesting balance.

Since we started with the market fee reward, a LTM will have one object per asset reward, which can be a very large number.

I feel that a table structure would be beneficial for the usage of this.

Proposed Structure

The table should be sortable and searchable by "ID" and "Type".

ID Type Balance Required Earned Remaining Available Action
1.13.001 Cashback 80 BTS 1000 coin days 800 coin days 200 coin days 80% [Claim]
1.13.002 Market Fee 10 bitUSD - - - 100% [Claim]
1.13.003 Other 300 MYASSET 100 days 50 days 50 days 0% -
@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [5a] Tiny Indicates size of task. Est. less than one hour labels Jul 24, 2019
@startailcoon startailcoon added this to the Active Development milestone Jul 24, 2019
@startailcoon startailcoon changed the title [1] Update Vesting Balances to Table Style [2] Update Vesting Balances to Table Style Jul 24, 2019
@sschiessl-bcp sschiessl-bcp self-assigned this Jul 26, 2019
@sschiessl-bcp sschiessl-bcp added the [7] Estimated Administration flag, notifies hours are estimated and requires revisiting label Aug 6, 2019
sschiessl-bcp pushed a commit that referenced this issue Aug 6, 2019
…_Balances_to_Table_Style

#2979 update vesting balances to table style
@sschiessl-bcp
Copy link
Contributor

Bounty request in #3014 (comment)

@startailcoon startailcoon changed the title [2] Update Vesting Balances to Table Style [3] Update Vesting Balances to Table Style Aug 6, 2019
@startailcoon
Copy link
Contributor Author

The state isn't updated correctly when switching between accounts in the header menu.

retrieveVestingBalances() is called correctly, when the account changes, but the following doesn't update correctly and needs checking.

this.setState({vesting_balances});

@startailcoon startailcoon reopened this Aug 11, 2019
@sschiessl-bcp
Copy link
Contributor

Fixed de1d7b5

@startailcoon
Copy link
Contributor Author

startailcoon commented Aug 12, 2019

Fixed de1d7b5

Was this the only requirements to make this work?
I've verified it and it works much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5a] Tiny Indicates size of task. Est. less than one hour [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants