-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment for BUY/SELL ORDER click #2700
Comments
When you click on the orderbook row of another order, that is the price your form will fill out. You have to manually change that price to suit your needs. I don't think we should manipulate the price to anything else as the user would expect the price to be that one and nothing else. However, I see your point, but can't see that we have any good ways to handle them automatically for the user without making it all very confusing. |
My idea was to highlight a
|
I like the possibility of your idea @sschiessl-bcp. Making this possible when you hover with a mouse I see no issues with. A mobile device is a but trickier. But if we can find a good way to do this, perhaps it can help with #2563 |
I thought I've fixed the rounding error, when you click on the order book you always get a price which is able to fill when you click. However, because some markets are moving quickly, when confirming the new order, perhaps it won't fill, that's why people want to manually adjust price after clicked. A simple approach for the user is to click on an order deeper on the book but not the top ones. Or we can a button to slightly decrease selling price. For people who don't want their orders to be matched instantly, a button to slightly increase selling price makes sense. So my idea is to add two buttons in the "new order" box, price row, E.G.
When clicking on |
Sometimes I am ahead of the clicked order, sometimes I am behind the clicked order
Doesn't solve the problem.
If I increase my buy order or decrese my sell order, my order will be matched more likely.
Or rethink the rounding ?
Please keep in mind (1+10⁻5)^100 is only a increase of 0.1% Options:
I favorite the last two options |
Current behavior is: if you click on a sell order on the order book, don't change the price, submit a buy order, then your order will match with the sell order. If your order didn't match, then it's a bug related to rounding, which should have been fixed in #565. @froooze I guess I got what you want. You clicked on sell order on the order book, and submitted a new sell order, you expected that your sell order will be in front of the order you clicked. Yes, this is a new feature. The UI don't know whether the user want to place a new order in front of the order she clicked, thus buttons to quickly adjust price makes sense. |
About UX: When placing a new order, On many exchanges, traders input price and amount1, the amount2 is derived. On BitShares, actually traders input 2 amounts, the price is derived. So, for the feature requested in this issue, it's wise to lock the smaller (in Satoshi) amount and adjust the bigger amount by 1 Satoshi or a few Satoshis, let the price change by itself. It's annoying that there is no lock button on trading page like we have when adjusting debt position. |
Regarding locking any of the inputs, like we have on the debt position we have issue #2075 on that. I guess that issue would solve this one, perhaps together with an easy way to increase/decrease the non-locked input field. |
Is your feature request related to a problem? Please describe.
When filling the order book, I want to place my order slightly ahead of certain spots.
Now it depends on the rounding error, where my new order will be placed or I have to manually edit my sell/buy price.
Describe the solution you'd like
The BUY ORDER click should be multiplied by (1 + 10⁻5) for the input field number.
The SELL ORDER click should be multiplied by (1 - 10⁻5) for the input field number.
Additional context
This should also help to improve order book depth and spread.
The text was updated successfully, but these errors were encountered: