[5] Deposit/Withdraw Modal - Add GDEX Support

[wmbutler]

No description provided.

[startailcoon]

I'll take this

[startailcoon]

Extended this issue to include Deposit as well.

GDEX will require some work since their API isn't sending the data back as the others are. Their JSON structure will have to be compiled to something that we commonly use for the other backers.

[wmbutler]

Let's reach out to GDEX and see if they will provide / adopt this conforming API call.

{  
   "coinType":"bts",
   "walletName":"BitShares 2.0",
   "name":"BitShares",
   "symbol":"BTS",
   "walletSymbol":"BTS",
   "walletType":"bitshares2",
   "transactionFee":"0.",
   "precision":"100000.",
   "backingCoinType":null,
   "supportsOutputMemos":true,
   "restricted":false,
   "authorized":null,
   "notAuthorizedReasons":null,
   "gateFee":0,
   "intermediateAccount":"openledger-wallet",
   "coinPriora":0
}

[wmbutler]

Waiting for GDEX response.

[abitmore]

I'll help contact GDEX.

[startailcoon]

As a follow-up on what GDEX is doing today.

Today GDEX handles returned data from their APIs with the following code, that transforms it into an array like the following. This does not comply with how we handle gateway assets otherwise.

bitshares-ui/app/components/DepositWithdraw/gdex/GdexGateway.jsx

Line 76 in 7a2420f

_transformCoin(data) {

{
  "innerAssetId": 1002,
  "innerAssetName": "GDEX.BTC",
  "innerSymbol": "GDEX.BTC",
  "outerAssetId": 1001,
  "outerAssetName": "bitcoin",
  "outerSymbol": "BTC",
  "status": 0,
  "gateFee": 0,
  "needMemo": 0,
  "minTransactionAmount": 1e-8,
  "type": 2,
  "relationPrecision": 8
}

[tianyekuo]

We will look into it. I notice there are 3 APIs: coins, trading-paires, active-wallet. Are they all necessery?
@startailcoon

[wmbutler]

I think all we are missing is intermediateAccount. It's possible this could be hardcoded to whatever value crypto-bridge uses, or maybe @mindphlux1 would either update the api or confirm the proper intermediateAccount to uses.

[tianyekuo]

intermediateAccount is crypto in anthor API.
Just add intermediateAccount in the asset list(coins) api for show , is that ok?

[startailcoon]

There are a few different ways we do the connections for backed coins. Let me compile a list for you what we need for each.

[startailcoon]

I've looked through the function of GDEX today, and it's quite different approach from what the other gateways uses. Both in fetching assets and linking the backing wallet and asset.

It's not impossible to make this work together with the new modal, together with the other gateways.

• Either we build a new function that handles the GDEX way but will require some additional code.
• Or GDEX applies the way the wallet works with now.

I'm compiling a document explaining the current system that the gateways uses, which I will submit in a few days when I've gotten everything correct.

I recommend we look over a possible merge after this.

[wmbutler]

Maybe we just close this and don't include GDEX on the reference wallet since they aren't expressing interest in being part of the discsussion.

[tianyekuo]

Sorry for late response, since the APIs do not work with other gateways, we will make a new set of APIs.

Implement the 3 APIs coins, trading-paires, active-wallet is all we need? @startailcoon @wmbutler

[tianyekuo]

If gdex want to catch up the milestone 21, could you give some help, thanks!

[startailcoon]

I'm working on a document for what is required, why and how. Give me a few days.

Including in next milestone would probably be possible if it turns out good.

[tianyekuo]

Thanks you, I will wait for your good news.

[startailcoon]

Moving this to the next milestone as it's quite a challenge to make sure this works.

[startailcoon]

@tianyekuo I have updated a draft documentation for how the Gateway Integration works in the Bitshares UI Reference wallet.

You can review this on https://github.com/bitshares/bitshares-ui/wiki/Gateway-Integration-Requirements

[wmbutler]

We pushed the release to 4/18. Any chance you can get this in prior to release? @tianyekuo

[startailcoon]

I think it's to little time and I have yet no response from @tianyekuo as well as a very busy schedule at the moment.

I'm also still waiting for approval of my current changes and last minute fixes for it, if needed, which is my priority this milestone.

I do not want to rush this, nor take a task I can't complete.

I'm happy to do the task though.

[tianyekuo]

Our APIs will adjust as the document required, we try to finish it early next week. The next milestone(5/1) is better. Would that be OK with you guys.

[startailcoon]

Great news 👍

[startailcoon]

Issue Update

After extensive communication with Brian Zhang from the GDEX Exchange, we are now very close to add their new API calls to the Deposit/Withdraw Modals.

A few changes to the overall structure will be done to accommodate a few case specific things for GDEX.

We are still on the track to have this completed for the set time.

[wmbutler]

@startailcoon great work. Really appreciate you going the extra mile on this.

[tianyekuo]

@startailcoon , thanks for your great work, the document makes the integration better.

[startailcoon]

Forked update for BitShares UI with GDEX Gateway support is now available at https://github.com/bitshares/bitshares-ui/tree/1276_GDEXGateway

The following is not included in this as discussed

• Required User agreement approval
• Beta user setting
• Other GDEX specific actions

The old Withdraw/Deposit page will still have all the old bells and whistles and have not changed.

This should be checked and signed of by the GDEX team before merging.

[wmbutler]

@tianyekuo

[tianyekuo]

That's great, please help to release it, thanks!