Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Book Improvements #1062

Open
10 tasks
wmbutler opened this issue Jan 24, 2018 · 21 comments
Open
10 tasks

Order Book Improvements #1062

wmbutler opened this issue Jan 24, 2018 · 21 comments
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Needs Discussion More discussion is required before implemented or worked on [3] Feature Classification indicating the addition of novel functionality to the design [5e] Huge Indicates size of task. Est. more than ten hours (Recommended to split in tasks)

Comments

@wmbutler
Copy link
Contributor

wmbutler commented Jan 24, 2018

The order book is a little busy. It's not really wide enough to warrant striped rows. Let's remove those. Also, if we can give a reference to the depth chart here with significant markers, it may remove the need for the depth chart toggle. This allows the user to have more information without toggling. This is a rough start and intended to spark discussion. I also noticed that most charting systems only show the size of the order for one side of the market.

I.e., if we are on BTS/USD, everything is priced in USD.

screen shot 2018-01-23 at 8 05 00 pm

Notes

  • Gray tick Call Limit
  • Red Tick Settlement
  • Yellow Tick Margin Call
  • Bars are cumulative orders
  • Hovering over each bar makes it a stronger version of that color and also lights up the corresponding value in the Exchange Header.
  • Dark black background (hover state)
  • Entire area scrolls (not separate scrolling areas for bid and ask)
  • Only show order size (quantity) and price for one side of the market
  • Decimals but all be in line
  • Extra credit: dim gray for all insignificant leading and trailing zeros
@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Jan 24, 2018
@wmbutler wmbutler added this to the 180215 milestone Jan 24, 2018
@vanissoft
Copy link

Nice look, although big depth chart is a need.
+1 to be priced in base asset.

@fractalnode
Copy link

we can not turn this large portion of information into such a small portion

info

@wmbutler
Copy link
Contributor Author

We can still keep the toggle for the Market Depth. I won't use it, but no reason to get rid of the option.

@abitmore
Copy link
Member

I don't think it's a good idea to remove the total value column from the order book.

  1. It's very convenient for traders,
  2. due to the implementation in core, prices showing on the book are usually inaccurate.

@tbone-bts
Copy link

tbone-bts commented Jan 28, 2018

I agree with @abitmore re: cumulative quantity column on the order book. It will be very inconvenient if you remove it.

@wmbutler
Copy link
Contributor Author

wmbutler commented Jan 28, 2018

When you say "Total Value", what are you referring to? All I see is the asset quantity in each side of the trade. As far as cumulative quantity, that doesn't exist in the order book as you can see from this screenshot.

screen shot 2018-01-28 at 1 34 29 pm

@tbone-bts
Copy link

Your screenshot shows three columns: (1) price (which for clarity should really be labeled bid/ask), (2) quantity of the asset being traded (in this case the quantity of BTS), and (3) price x quantity (i.e. total value of the bid or ask in terms of the base asset, in this case USD).

Also, you're looking at the vertical order book, which is ok for just watching a market...but not great for placing trades. The horizontal order book, on the other hand, has a 4th column displaying the cumulative running total of the value all bids (or asks) up to and including that row. That is very, VERY useful.

When you say "Total Value", what are you referring to? All I see is the asset quantity in each side of the trade. As far as cumulative quantity, that doesn't exist in the order book as you can see from this screenshot.

screen shot 2018-01-28 at 1 34 29 pm

@wmbutler
Copy link
Contributor Author

This issue isn't proposing to make changes to the horizontal order book. Let's not confuse things. My points remain the same:

  • There is no cumulative value in the existing vertical order book
  • It's quite standard across exchanges to only display pricing in the purchase currency

@abitmore
Copy link
Member

When you say "Total Value", what are you referring to? All I see is the asset quantity in each side of the trade. As far as cumulative quantity, that doesn't exist in the order book as you can see from this screenshot.

I mean the screenshot in OP shows only 2 columns. I like 3.

@wmbutler
Copy link
Contributor Author

wmbutler commented Jan 29, 2018

I'm not sure it makes sense to show 3. Looking across many different trading platforms, this is not accepted practice and I think it adds to confusion when new users hit our platform.

@abitmore
Copy link
Member

Top crypto exchanges:

  1. binance, showing 3: https://www.binance.com/trade.html?symbol=ETH_BTC
  2. OKEx, horizontal layout, showing 2: https://www.okex.com/spot.html
    More others to be added here.

@wmbutler
Copy link
Contributor Author

Point taken. Thanks.

  • Keep pricing in both assets.

@wmbutler wmbutler modified the milestones: 180215, 180301 Feb 17, 2018
@wmbutler wmbutler modified the milestones: 180301, 180401 Mar 1, 2018
@wmbutler wmbutler modified the milestones: 180401, 180501 Mar 14, 2018
@calvinfroedge calvinfroedge self-assigned this Mar 28, 2018
@abitmore
Copy link
Member

@calvinfroedge what's the progress so far? If you haven't started working on it, can you release it so I can ask @ety001 to work on it after finished #1106?

@wmbutler
Copy link
Contributor Author

This needs to be worked on with @ahdigital as well. He is doing a full UX on the Exchange. #1449

@abitmore
Copy link
Member

@wmbutler I feel that @ahdigital is overloaded, in the meanwhile we have quite some developers that can code now. Please prioritize things.

@abitmore
Copy link
Member

Seems it has been implemented here: https://www.hellobts.com/market/BTS_CNY

@wmbutler wmbutler added this to the 180803 milestone Jul 23, 2018
@wmbutler wmbutler modified the milestones: 180801, 180815 Aug 6, 2018
@wmbutler wmbutler modified the milestones: 180815, 180905 Aug 26, 2018
@wmbutler wmbutler modified the milestones: 180905, 180919 Sep 13, 2018
@wmbutler wmbutler modified the milestones: 180919, 181003 Sep 25, 2018
@wmbutler wmbutler added this to the 181031 milestone Oct 11, 2018
@startailcoon startailcoon added [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [5e] Huge Indicates size of task. Est. more than ten hours (Recommended to split in tasks) labels Oct 13, 2018
@wmbutler wmbutler modified the milestones: 181031, 181128 Nov 18, 2018
@startailcoon startailcoon modified the milestones: 181128, 190103 Dec 1, 2018
@startailcoon startailcoon modified the milestones: 190103, 190313 Feb 12, 2019
@MikhailKavalenka
Copy link
Contributor

@startailcoon , Do we only need to show the depth chart representation on the order book sections in vertical mode? Or the scope of the issue is more then that?

@startailcoon
Copy link
Contributor

@MikhailKavalenka for me it would make sense to have this in the orderbook, regardless of position of it. So I would say it should be both cases.

@clockworkgr clockworkgr modified the milestones: 190315, 190329 Mar 20, 2019
@clockworkgr clockworkgr modified the milestones: 190329, 190412 Apr 3, 2019
@startailcoon startailcoon modified the milestones: 190412, 190426 Apr 14, 2019
@startailcoon startailcoon removed this from the 190426 milestone Apr 28, 2019
@startailcoon startailcoon changed the title [12] Order Book Improvements Order Book Improvements May 28, 2019
@startailcoon startailcoon added the [2] Needs Discussion More discussion is required before implemented or worked on label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Needs Discussion More discussion is required before implemented or worked on [3] Feature Classification indicating the addition of novel functionality to the design [5e] Huge Indicates size of task. Est. more than ten hours (Recommended to split in tasks)
Projects
None yet
Development

No branches or pull requests

10 participants