Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build for boost 1.72.0 #190

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Conversation

nathanielhourt
Copy link

Definitely something strange going on here, as in my environment
the value of Boost_UNIT_TEST_FRAMEWORK_LIBRARY is
"Boost::unit_test_framework"... So this is my fix, but probably
something else should be done.

Boost 1.72.0

Definitely something strange going on here, as in my environment
the value of Boost_UNIT_TEST_FRAMEWORK_LIBRARY is
"Boost::unit_test_framework"... So this is my fix, but probably
something else should be done.

Boost 1.72.0
@abitmore abitmore added this to the core release 4.1.0 milestone Mar 18, 2020
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't break old env, but if there are new issues with new versions of boost or cmake, a real fix will be needed in the future. Approving for progress.

@abitmore abitmore merged commit 9dbf944 into bitshares:master Mar 18, 2020
@nathanielhourt nathanielhourt deleted the fix-2 branch March 18, 2020 23:52
@abitmore abitmore changed the title Fix Build Fix Build for boost 1.72.0 Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants