Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bloom_filter.hpp… #176

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Updated bloom_filter.hpp… #176

merged 2 commits into from
Nov 6, 2019

Conversation

pmconrad
Copy link

@pmconrad pmconrad commented Nov 4, 2019

from https://github.com/ArashPartow/bloom/blob/c89c2912c445dd5c0afe3d819ca012a6c6639e4e/bloom_filter.hpp

Most notably, the upstream license has changed to MIT, which should simplify #13

@abitmore abitmore added this to the core release 4.1.0 milestone Nov 4, 2019
Copy link

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing in some areas are not in line with our standards, but I believe this is forgivable for 3rd party code. There are a few other comments below, which are more curiosity than pointing out issues. Changes look good. It works well on Ubuntu 18.04 / Boost 1.65.1

include/fc/bloom_filter.hpp Show resolved Hide resolved
include/fc/bloom_filter.hpp Outdated Show resolved Hide resolved
Copy link

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Peter! Tested on Ubuntu 18.04 / Boost 1.65.1.

@pmconrad pmconrad merged commit e5ab69a into master Nov 6, 2019
@pmconrad pmconrad deleted the bloom_update branch November 6, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants