Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed stacktrace test #174

Closed
wants to merge 1 commit into from
Closed

Fix failed stacktrace test #174

wants to merge 1 commit into from

Conversation

jmjatlanta
Copy link

The result is platform / version dependent. Increase the range to avoid failure on Ubuntu 18.04 / Boost 1.69 / g++ 7.4.0

@pmconrad
Copy link

Hm. For a static_variant with only 8 member types, stack depth 10 seems like a lot. Have you checked what these 8 levels are?
Maybe add more types to the static_variant? The point of the test is to verify that the stack depth is a small constant and does not depend on the member count.

@abitmore abitmore added this to the core release 4.1.0 milestone Nov 8, 2019
@pmconrad
Copy link

Added a similar fix in #180 plus one for the latest OpenSSL-1.1.1 (github auto-build uses latest Ubuntu as well).

@oxarbitrage
Copy link
Member

replaced by #180

@abitmore abitmore removed this from the core release 4.1.0 milestone Nov 29, 2019
@abitmore abitmore deleted the jmj_stacktrace_test branch April 29, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmjatlanta @pmconrad @oxarbitrage @abitmore