782 part1 #1478
782 part1 #1478
Conversation
updates on 12/20
| @@ -40,6 +40,7 @@ namespace graphene { namespace app { | |||
| public: | |||
| bool enable_subscribe_to_all = false; | |||
| bool has_market_history_plugin = false; | |||
| uint32_t max_account_history_operations_limit=100; | |||
There was a problem hiding this comment.
I think this is not needed.
There was a problem hiding this comment.
-Not needed for base scenario
-However needed for scenario from test case where initialization is not provided. Additionally this is part of the clarification I needed relating to below. More details in the main ticket (#782)
Needed clarification on :
1.
On running function get_account_history_operations located in file history_api_test.cpp, config.init file is not loaded , can you suggest any approach to test the API ?
image
I am using ilog function for debugging the shared_pointers as I face BOOST error for the RTTI symbols not found. In my company the team uses CLION IDE with GDB and found it to be more time-saving than ilog. I am open for any better way to debug and open to connect with any technical member for the same.
There was a problem hiding this comment.
On running function get_account_history_operations located in file history_api_test.cpp, config.init file is not loaded , can you suggest any approach to test the API ?
To my knowledge, we don't have tests that use config files. Best approach might be to derive a subclass from database_fixture that creates and uses a config file in graphene::utilities::temp_directory_path().
There was a problem hiding this comment.
On running function get_account_history_operations located in file history_api_test.cpp, config.init file is not loaded , can you suggest any approach to test the API ?
To my knowledge, we don't have tests that use config files. Best approach might be to derive a subclass from database_fixture that creates and uses a config file in
graphene::utilities::temp_directory_path().
Thank you I shall explore above approach.
In addition if I start witness node and hit the API for function get_account_history_operations, would this option work? I shall explore this too and update.
There was a problem hiding this comment.
updated based on review changes of @oxarbitrage . 3 changes can be viewed under "File changes" section.
| @@ -982,6 +988,8 @@ void application::set_program_options(boost::program_options::options_descriptio | |||
| ("enable-standby-votes-tracking", bpo::value<bool>()->implicit_value(true), | |||
| "Whether to enable tracking of votes of standby witnesses and committee members. " | |||
| "Set it to true to provide accurate data to API clients, set to false for slightly better performance.") | |||
| ("max-account-history-operations-limit",boost::program_options::value<uint32_t>()->default_value(100), | |||
| "For history_api::get_account_history_operations to increase its limited value default is 100") | |||
There was a problem hiding this comment.
Better "set" instead of "increase" (could also be used to decrease from default)
|
resolved the above and create a new pull request #1513 |
1 similar comment
|
resolved the above and create a new pull request #1513 |
this is the part to increase the hard coded limit on the get_account_history_operations api call