Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update_expired_feeds performance #1093 #1180

Merged
merged 16 commits into from
Jul 27, 2018
Merged

Improve update_expired_feeds performance #1093 #1180

merged 16 commits into from
Jul 27, 2018

Commits on Jul 25, 2018

  1. Added logging for the old update_expired_feeds bug 

    The old bug is cryptonomex/graphene#615 .

Due to the bug, `update_median_feeds()` and `check_call_orders()`
will be called when a feed is not actually expired, normally this
should not affect consensus since calling them should not change
any data in the state.

However, the logging indicates that `check_call_orders()` did
change some data under certain circumstances, specifically, when
multiple limit order matching issue (#453) occurred at same block.
* #453
    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    adb7785 View commit details
    Browse the repository at this point in the history

  2. Minor performance improvement for price::is_null()

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    d83325b View commit details
    Browse the repository at this point in the history

  3. Use static refs in db_getter for immutable objects

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    73d61a2 View commit details
    Browse the repository at this point in the history

  4. Minor performance improvement for db_maint

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    6a2ffbc View commit details
    Browse the repository at this point in the history

  5. Minor code updates for asset_evaluator.cpp 

    * changed an `assert()` to `FC_ASSERT()`
* replaced one `db.get(asset_id_type())` with `db.get_core_asset()`
* capture only required variables for lambda
    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    7667429 View commit details
    Browse the repository at this point in the history

  6. Improve update_expired_feeds performance #1093

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    6efa0f2 View commit details
    Browse the repository at this point in the history

  7. Change static refs to member pointers of db class

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    0421abf View commit details
    Browse the repository at this point in the history

  8. Added getter for witness schedule object

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    c9e09aa View commit details
    Browse the repository at this point in the history

  9. Added getter for core dynamic data object

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    0f7804e View commit details
    Browse the repository at this point in the history

  10. Use getters

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    80620eb View commit details
    Browse the repository at this point in the history

  11. Removed unused variable

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    bcafc0c View commit details
    Browse the repository at this point in the history

  12. Add comments for update_expired_feeds in db_block

    @abitmore
    abitmore committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    60e9314 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2018

  1. Minor refactory asset_create_evaluator::do_apply()

    @abitmore
    abitmore committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    08e9e0a View commit details
    Browse the repository at this point in the history

  2. Simplified code in database::pay_workers()

    @abitmore
    abitmore committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    78ff14e View commit details
    Browse the repository at this point in the history

  3. Added FC_ASSERT for dynamic data id of core asset

    @abitmore
    abitmore committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    4d40398 View commit details
    Browse the repository at this point in the history

  4. Added header inclusions in db_management.cpp

    @abitmore
    abitmore committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    696ed6a View commit details
    Browse the repository at this point in the history