Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many FC_ASSERTs & FC_THROW_EXCEPTIONs have incorrent format str or empty str, prevent display more message. #943

Closed
btsabc opened this issue May 22, 2018 · 2 comments
Assignees

Comments

@btsabc
Copy link

btsabc commented May 22, 2018

eg:

FC_ASSERT( maybe_found != nullptr, "Unable to find Object", ("id",id) );

get_call_orders "1.3.0" 1
ouput:
Assert Exception: maybe_found != nullptr: Unable to find Object

if code change to:
FC_ASSERT( maybe_found != nullptr, "Unable to find Object ${id}", ("id",id) );
will show id msg,more helpful.

@abitmore
Copy link
Member

Thanks, created PR #945 for the mentioned one.

If found more, can add them to #691.

@abitmore abitmore self-assigned this May 22, 2018
@abitmore
Copy link
Member

Closed with #945 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants