Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate SonarCloud #836

Closed
abitmore opened this issue Apr 10, 2018 · 4 comments
Closed

Integrate SonarCloud #836

abitmore opened this issue Apr 10, 2018 · 4 comments
Labels
1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2d Developing Status indicating currently designing and developing a solution 3b Feature Classification indicating the addition of novel functionality to the design 6 Build Impact flag identifying the build process dev workflow
Milestone
201808 - Non-Cons...

Comments

@abitmore
Copy link
Member

abitmore commented Apr 10, 2018 •
edited
Loading

SonarCloud is a code analysis service. More info: https://about.sonarcloud.io/.

Done: https://sonarcloud.io/dashboard?id=BitShares_Core
@oxarbitrage oxarbitrage added the 2a Discussion Needed Prompt for team to discuss at next stand up. label May 9, 2018
@oxarbitrage
Copy link
Member

here is the develop branch that was added by @pmconrad already:

https://sonarcloud.io/dashboard?id=BitShares-develop%3Adevelop

i think we should add our our branches master, hardfork, testnet and develop. Also project Bitshares-FC the master branch.

more discussion and assignee is needed.

@pmconrad
Copy link
Contributor

pmconrad commented May 9, 2018

I think it is possible to integrate the sonar scan into automated build processes. The only issue is how to hide the sonar token from external viewers.

@pmconrad
Copy link
Contributor

pmconrad commented May 9, 2018

https://docs.travis-ci.com/user/encryption-keys/
Branch handling can be done better now than what I did - https://docs.sonarqube.org/display/PLUG/Branch+Plugin - master, hardfork, testnet and develop would be "Long lived", everything else short lived. Or sth like that.

@pmconrad pmconrad self-assigned this May 11, 2018
@ryanRfox ryanRfox self-assigned this May 24, 2018
@ryanRfox ryanRfox added 1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2d Developing Status indicating currently designing and developing a solution 3b Feature Classification indicating the addition of novel functionality to the design 6 Build Impact flag identifying the build process and removed 2a Discussion Needed Prompt for team to discuss at next stand up. labels Jun 6, 2018
This was referenced Jun 23, 2018
Merged
Closed
@oxarbitrage
Copy link
Member

closed by #1081

@abitmore abitmore mentioned this issue Aug 4, 2018
Closed
@abitmore abitmore mentioned this issue Nov 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2d Developing Status indicating currently designing and developing a solution 3b Feature Classification indicating the addition of novel functionality to the design 6 Build Impact flag identifying the build process dev workflow
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

No branches or pull requests
4 participants
@pmconrad @abitmore @ryanRfox @oxarbitrage