Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow in "by num" percentage calculation in replay status messages #2243

Closed
17 tasks
abitmore opened this issue Aug 22, 2020 · 1 comment · Fixed by #2246
Closed
17 tasks

Overflow in "by num" percentage calculation in replay status messages #2243

abitmore opened this issue Aug 22, 2020 · 1 comment · Fixed by #2246
Milestone
5.0.0 - Protocol ...

Comments

@abitmore
Copy link
Member

Bug Description

It seems there is an overflow when calculating "by num" percentages:

2020-08-22T13:45:59 th_a:?unnamed? reindex ] [by size: 93.36087% 79428274044 of 85076622421] [by num: 84.57161% 42940000 of 50773538] db_management.cpp:138
2020-08-22T13:46:15 th_a:?unnamed? reindex ] [by size: 93.38089% 79445307770 of 85076622421] [by num: 0.00064% 42950000 of 50773538] db_management.cpp:138

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Aug 22, 2020
@abitmore abitmore mentioned this issue Aug 22, 2020
Merged
@abitmore abitmore linked a pull request Aug 23, 2020 that will close this issue
Fix replay percent calculation #2246
Merged
@abitmore
Copy link
Member Author

Fixed by #2246.

@abitmore abitmore mentioned this issue Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0 - Protocol Upgrade Release
Development

Successfully merging a pull request may close this issue.

Fix replay percent calculation bitshares/bitshares-core
1 participant
@abitmore