Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error: sys/ioctl.h: No such file or directory when building on Mingw64 #1724

Closed
ShineQi opened this issue Apr 17, 2019 · 3 comments
Closed
Labels
6 Build Impact flag identifying the build process

Comments

@ShineQi
Copy link

ShineQi commented Apr 17, 2019

When building the develop branch on Msys2/Mingw64:

qx@DESKTOP-DFPMOLK MINGW64 ~/bitshares-core/build
$ make
[  0%] Performing build step for 'project_editline'
Makefile:919: warning: overriding recipe for target 'package'
Makefile:893: warning: ignoring old recipe for target 'package'
Makefile:919: warning: overriding recipe for target 'package'
Makefile:893: warning: ignoring old recipe for target 'package'
Making all in src
  CC       libeditline_la-editline.lo
C:/msys64/home/qx/bitshares-core/libraries/fc/vendor/editline/src/editline.c:25:10: fatal error: sys/ioctl.h: No such file or directory
 #include <sys/ioctl.h>
          ^~~~~~~~~~~~~
compilation terminated.
make[5]: *** [Makefile:441: libeditline_la-editline.lo] Error 1
make[4]: *** [Makefile:472: all-recursive] Error 1
make[3]: *** [Makefile:360: all] Error 2
make[2]: *** [libraries/fc/CMakeFiles/project_editline.dir/build.make:113: libraries/fc/vendor/editline/src/project_editline-stamp/project_editline-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:142: libraries/fc/CMakeFiles/project_editline.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Google search tells editline don't support Mingw. Can we just simply remove editline on Mingw? There's no editline on MSVC.
I think this is related to #1593.

@pmconrad
Copy link
Contributor

Yes we have disabled editline on windows builds because it's not supported. IMO it's OK do disable it in Mingw builds as well.

@abitmore abitmore added the 6 Build Impact flag identifying the build process label Apr 19, 2019
@abitmore abitmore added this to the 3.2.0 - Feature Release milestone Apr 19, 2019
@crypto-ape
Copy link
Contributor

Looks like it is related to bitshares/bitshares-fc#121

@ShineQi
Copy link
Author

ShineQi commented May 5, 2019

fixed by bitshares/bitshares-fc#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 Build Impact flag identifying the build process
Projects
None yet
Development

No branches or pull requests

4 participants