Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide useful logging in cli_wallet #1567

Closed
1 of 17 tasks
jmjatlanta opened this issue Feb 8, 2019 · 6 comments
Closed
1 of 17 tasks

Provide useful logging in cli_wallet #1567

jmjatlanta opened this issue Feb 8, 2019 · 6 comments

Comments

@jmjatlanta
Copy link
Contributor

User Story
As a cli_wallet user, I want to have a log of the communication between the wallet and the API server.

As a developer, these logs can assist in solving reported problems and debugging software problems.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context
See #1528 (comment)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@jmjatlanta
Copy link
Contributor Author

@cogutvalera please provide an estimate of what it will take to implement this.

@cogutvalera
Copy link
Member

@jmjatlanta Thank you very much ! I want to take this issue ! I will estimate this issue soon ...

@abitmore
Copy link
Member

abitmore commented Feb 8, 2019

IMHO this has been done via #1528. I created #1570 for another needed feature.

@jmjatlanta
Copy link
Contributor Author

The intent was that #1528 solves a bug that prevented logging from actually happening. But the logging that was created was not very useful. As your comment at #1528 (comment) suggests, it would be better to log some details of the communications between the client and server.

It looks like #1570 is between the another app and the wallet in daemon mode.

Am I misinterpreting the intent of your comment in 1528?

@jmjatlanta
Copy link
Contributor Author

Closing this in favor of #1570

@oxarbitrage
Copy link
Member

closed by #1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants