Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart_ref causes build issues #1548

Closed
1 of 3 tasks
jmjatlanta opened this issue Jan 31, 2019 · 1 comment
Closed
1 of 3 tasks

smart_ref causes build issues #1548

jmjatlanta opened this issue Jan 31, 2019 · 1 comment
Assignees
@jmjatlanta
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 Build Impact flag identifying the build process
Milestone
3.1.0 - Feature R...

Comments

@jmjatlanta
Copy link
Contributor

jmjatlanta commented Jan 31, 2019 •
edited
Loading

Some platforms are very picky about including headers. That is fine. But there is one header that constantly needs to be added, and it seems to be fairly needless...

fc::smart_ref, as its name implies, attempts to be a "smart reference". It is used in only 1 area of Bitshares, having to do with the collection of fee parameters. Due to the design, each user of fee parameters (many) must also include the smart_ref header, otherwise certain platforms (esp. macOS) will not compile.

There have been many pull requests and issues to add this header to various files to complete compilation on various platforms. This issue is to find and implement a viable replacement with less hastle.

Related: #1547 (comment)
and: #1516 (comment)

Steps To Reproduce
On macOS, follow the normal steps to compile the current master branch. The compilation will fail due to smart_ref.

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Provide build guidance
  • Create Bug Report
@pmconrad pmconrad added 3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 Build Impact flag identifying the build process labels Jan 31, 2019
@jmjatlanta jmjatlanta self-assigned this Feb 4, 2019
This was referenced Feb 5, 2019
Merged
Merged
Closed
@abitmore abitmore added this to the Future Feature Release milestone Feb 5, 2019
@jmjatlanta jmjatlanta mentioned this issue Feb 15, 2019
Merged
@jmjatlanta
Copy link
Contributor Author

Fixed by PR #1556

@MichelSantos MichelSantos mentioned this issue May 1, 2019
Closed
@nathanielhourt nathanielhourt mentioned this issue Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmjatlanta jmjatlanta

Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 Build Impact flag identifying the build process
Projects
None yet
Milestone
3.1.0 - Feature Release
Development

No branches or pull requests
3 participants
@jmjatlanta @pmconrad @abitmore