Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Cases for PR 1270 (MCR Bugfix) #1423

Closed
6 of 10 tasks
ryanRfox opened this issue Nov 8, 2018 · 4 comments
Closed
6 of 10 tasks

Test Cases for PR 1270 (MCR Bugfix) #1423

ryanRfox opened this issue Nov 8, 2018 · 4 comments
Assignees
@oxarbitrage
Labels
1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3a Request Classification (default) which does not fit as a Feature, Enhancement or Bug. Core Team to evaluate 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 Protocol Impact flag identifying the blockchain logic, consensus, validation, etc.
Milestone
3.0.0 - Protocol ...

Comments

@ryanRfox
Copy link
Contributor

ryanRfox commented Nov 8, 2018 •
edited by oxarbitrage
Loading

Required Test Cases

  • modify old test cases related to margin calls, see if anything is broken after the new hard fork time
  • reproduce the issue before the hard fork time, aka changing MCR doesn't trigger margin calls (or push some call orders out of margin call territory)
    • go over the hard fork time, check if margin calls are triggered (or no longer triggered) as expected
  • changing MCR again after the hard fork time, check if margin calls are triggered correctly

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@ryanRfox ryanRfox added 1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3a Request Classification (default) which does not fit as a Feature, Enhancement or Bug. Core Team to evaluate 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 Protocol Impact flag identifying the blockchain logic, consensus, validation, etc. 0 Help Wanted Notification to Core Team that Assignee is seeking assistance, but is able to proceed labels Nov 8, 2018
@ryanRfox
Copy link
Contributor Author

ryanRfox commented Nov 8, 2018

It is my understanding the PR #1324 contains code for the bugfix of #1270 but lacks test cases. This issues to create those test cases.

Once the test cases are added to the PR, we can organize the dates for TESTNET.

@oxarbitrage oxarbitrage removed the 0 Help Wanted Notification to Core Team that Assignee is seeking assistance, but is able to proceed label Nov 9, 2018
@oxarbitrage oxarbitrage self-assigned this Nov 9, 2018
@oxarbitrage
Copy link
Member

#1469

@oxarbitrage
Copy link
Member

#1493

@oxarbitrage
Copy link
Member

oxarbitrage commented Jan 30, 2019 •
edited
Loading

closed by #1493 and #1469

@MichelSantos MichelSantos mentioned this issue Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
1c Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3a Request Classification (default) which does not fit as a Feature, Enhancement or Bug. Core Team to evaluate 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 Protocol Impact flag identifying the blockchain logic, consensus, validation, etc.
Projects
None yet
Milestone
3.0.0 - Protocol Upgrade Release
Development

No branches or pull requests
2 participants
@ryanRfox @oxarbitrage