unused variable fc::logging_config cfg in cli_wallet/main.cpp

[ihla]

The logging config is created but never used. I see in the "Initial commit" the commented line //fc::configure_logging( cfg ); probably deleted later on. We should either delete the dead code or put the fc::configure_logging( cfg ); back - what is desired? (Now there is a print on cosole saying "Logging RPC to file: logs/rpc/rpc.log" but logging is not happening!)

[abitmore]

CLI logging makes some sense when running in daemon mode.

But please be careful don't log sensitive info, e.g. wallet passwords or private keys.

[jmjatlanta]

I'm sorry, but I am missing something. I find no configure_logging in cli_wallet/main.cpp. Can you please clarify where the dead code is? I've checked the develop and master branches.

[ihla]

I consider these code lines as the dead code because the cfg is created but never passed to fc::configure_logging():

bitshares-core/programs/cli_wallet/main.cpp

Line 121 in 7d27ab1

fc::logging_config cfg;

bitshares-core/programs/cli_wallet/main.cpp

Lines 133 to 140 in 7d27ab1

	cfg.appenders.push_back(fc::appender_config( "default", "console", fc::variant(fc::console_appender::config(), 20)));
	cfg.appenders.push_back(fc::appender_config( "rpc", "file", fc::variant(ac, 5)));
	cfg.loggers = { fc::logger_config("default"), fc::logger_config( "rpc") };
	cfg.loggers.front().level = fc::log_level::info;
	cfg.loggers.front().appenders = {"default"};
	cfg.loggers.back().level = fc::log_level::debug;
	cfg.loggers.back().appenders = {"rpc"};

[ihla]

line fc::configure_logging(cfg); is missing in order to make the logging to work

[jmjatlanta]

Thank you for setting me straight. I now understand your OP. It sure would be nice to configure logging via a configuration file, but that is certainly a separate issue.

I'm with abitmore on this one. I believe we should call configure_logging( cfg ) for those using the wallet in daemon mode.

[oxarbitrage]

closed by #1528