Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document OPENSSL_CONF_SOURCE? #1147

Closed
abitmore opened this issue Jul 17, 2018 · 5 comments
Closed

Document OPENSSL_CONF_SOURCE? #1147

abitmore opened this issue Jul 17, 2018 · 5 comments
Labels
build About build process documentation

Comments

@abitmore
Copy link
Member

See changes done by bitshares/bitshares-fc#59. Mostly for building in Windows.

@abitmore abitmore added documentation build About build process labels Jul 17, 2018
@ryanRfox
Copy link
Contributor

@jmjatlanta May I request your assistance with some guidance on this one? I tried to trace back through the PR to determine what was originally desired. I'm not sure if the merged PR results in BOOST 1.67 and VS2017 support.

I see you translated the VS2015 document here:
https://gist.github.com/jmjatlanta/0b1bf8f5cc0ebf893e0b5a5bb65e9262
Can that be modified now to reflect the build process using VS2017?

Can we update our documentation to reflect BOOST [1.57 - 1.67] support?

I can surely do the latter, and am willing to try the former. Thanks for the guidance.

@jmjatlanta
Copy link
Contributor

Visual Studio: We have not successfully tested anything above Visual Studio 2015 Update 1. There have been attempts, but unsuccessful. I believe this is due to compiler differences, and not something simple. I will research some more.

Boost: There has been a change in Boost 1.66 in the way it handles exceptions that is incompatible with our undo process. See issue #852. Note in that issue that the problem that alerted us to this change has been fixed, but we need to do more testing.

So in brief, Boost 1.67 requires more testing, Visual Studio 2017 needs research.

@ryanRfox
Copy link
Contributor

Thanks @jmjatlanta for the clarification. Perhaps I can request @abitmore to provide more direction on what/where to document. Not sure if/what can be documented now, or leave this as a placeholder/to do after further testing noted above.

@jmjatlanta
Copy link
Contributor

jmjatlanta commented Jul 20, 2018

Okay, I am finally making progress on Windows builds. I'm not 100% there yet, but I am moving in the right direction.

As to this particular issue, CMake is expecting a file called openssl.cnf to be in a certain location. But that location is not guaranteed in Windows. So logic was added (bitshares/bitshares-fc#59) to make CMake look in a few places when in the Windows environment.

${OPENSSL_ROOT_DIR}/openssl.cnf (when using MinGW)
${OPENSSL_ROOT_DIR}/ssl/openssl.cnf (when using compilers other than MinGW)

In addition, users can now specifiy the CMake variable OPENSSL_CONF_SOURCE and set it to the location of their openssl.cnf file.

To satisfy this ticket, we need to document that this variable is available should someone need to use it, and perhaps document where openssl.cnf is looked for by default.

@jmjatlanta
Copy link
Contributor

The wiki mentions this new cmake variable. See https://github.com/bitshares/bitshares-core/wiki/BUILD_WinDevEnv

I will close this ticket as I believe that to be enough. If someone disagrees, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build About build process documentation
Projects
None yet
Development

No branches or pull requests

3 participants