Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation for initial_chain_id field when creating example genesis #1069

Closed
1 of 6 tasks
ryanRfox opened this issue Jun 18, 2018 · 5 comments
Closed
1 of 6 tasks

Update Documentation for initial_chain_id field when creating example genesis #1069

ryanRfox opened this issue Jun 18, 2018 · 5 comments
Assignees
@pmconrad
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2g Final Review Status indicating the solution passes the test case(s) and is being reviewed for final acceptance. 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added
Milestone
3.1.0 - Feature R...

Comments

@ryanRfox
Copy link
Contributor

User Story
As a developer I want documentation detailing how the initial_chain_id is calculated for create_example_genesis so that I am aware of the inconsistent serialization pattern.

Additional Context (optional)
This is a short term documentation fix for the to-be-fixed-later #1068

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@ryanRfox ryanRfox added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added labels Jun 18, 2018
@windycrypto windycrypto mentioned this issue Jun 18, 2018
Closed
9 tasks
@ryanRfox
Copy link
Contributor Author

@cifer-lee I'm not too sure about my User story based on #1068 so I hope you can refine it as needed. If you will take this one, I'll have you work with @cedar-book to identify where in the documentation this notification should be located.

@cedar-book
Copy link

cedar-book commented Jul 7, 2018 •
edited
Loading

@ryanRfox, updated: please [] (moved) and let me know if this information would be enough or not.

@pmconrad
Copy link
Contributor

pmconrad commented Mar 1, 2019

Should remove the initial_chain_id from libraries/egenesis/genesis-dev.json

@pmconrad pmconrad mentioned this issue Mar 1, 2019
Merged
@pmconrad
Copy link
Contributor

pmconrad commented Mar 1, 2019

Documentation at http://dev.bitshares.works/en/master/development/testnets/private_testnet_genesis_example.html#private-testnet-genesis-example is clean.

@pmconrad pmconrad self-assigned this Mar 1, 2019
@pmconrad pmconrad added 2g Final Review Status indicating the solution passes the test case(s) and is being reviewed for final acceptance. and removed 2c Ready for Development Status indicating the Requirements are sufficent to begin designing a solution labels Mar 1, 2019
@pmconrad
Copy link
Contributor

pmconrad commented Mar 8, 2019

Closed via #1628

@pmconrad pmconrad closed this as completed Mar 8, 2019
@MichelSantos MichelSantos mentioned this issue May 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmconrad pmconrad

Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2g Final Review Status indicating the solution passes the test case(s) and is being reviewed for final acceptance. 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 5a Docs Needed Status specific to Documentation indicating the need for proper documentation to be added
Projects
None yet
Milestone
3.1.0 - Feature Release
Development

No branches or pull requests
3 participants
@pmconrad @ryanRfox @cedar-book