Merge pull request #1185 from bitshares/sonar_bugs

abitmore · web-flow · commit 1f625f8f6955 · 2018-07-26T21:33:28.000Z
Fix 2 bugs reported by sonarqube
diff --git a/libraries/plugins/snapshot/snapshot.cpp b/libraries/plugins/snapshot/snapshot.cpp
@@ -92,7 +92,7 @@ static void create_snapshot( const graphene::chain::database& db, const fc::path
    {
       out.open( dest );
    }
-   catch ( fc::exception e )
+   catch ( fc::exception& e )
    {
       wlog( "Failed to open snapshot destination: ${ex}", ("ex",e) );
       return;
@@ -104,7 +104,7 @@ static void create_snapshot( const graphene::chain::database& db, const fc::path
          {
             db.get_index( (uint8_t)space_id, (uint8_t)type_id );
          }
-         catch (fc::assert_exception e)
+         catch (fc::assert_exception& e)
          {
             continue;
          }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ static void create_snapshot( const graphene::chain::database& db, const fc::path`
`92`	`92`	`{`
`93`	`93`	`out.open( dest );`
`94`	`94`	`}`
`95`		`- catch ( fc::exception e )`
	`95`	`+ catch ( fc::exception& e )`
`96`	`96`	`{`
`97`	`97`	`wlog( "Failed to open snapshot destination: ${ex}", ("ex",e) );`
`98`	`98`	`return;`
`@@ -104,7 +104,7 @@ static void create_snapshot( const graphene::chain::database& db, const fc::path`
`104`	`104`	`{`
`105`	`105`	`db.get_index( (uint8_t)space_id, (uint8_t)type_id );`
`106`	`106`	`}`
`107`		`- catch (fc::assert_exception e)`
	`107`	`+ catch (fc::assert_exception& e)`
`108`	`108`	`{`
`109`	`109`	`continue;`
`110`	`110`	`}`