reject oversized transactions

jmjatlanta · jmjatlanta · commit 0b7cc7ef61d1 · 2019-02-27T09:56:34.000-05:00
diff --git a/libraries/chain/db_block.cpp b/libraries/chain/db_block.cpp
@@ -223,6 +223,8 @@ bool database::_push_block(const signed_block& new_block)
  */
 processed_transaction database::push_transaction( const precomputable_transaction& trx, uint32_t skip )
 { try {
+   // see https://github.com/bitshares/bitshares-core/issues/1573
+   FC_ASSERT( fc::raw::pack_size( trx ) < (1024 * 1024), "Transaction exceeds maximum transaction size." );
    processed_transaction result;
    detail::with_skip_flags( *this, skip, [&]()
    {

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,8 @@ bool database::_push_block(const signed_block& new_block)`
`223`	`223`	`*/`
`224`	`224`	`processed_transaction database::push_transaction( const precomputable_transaction& trx, uint32_t skip )`
`225`	`225`	`{ try {`
	`226`	`+ // see https://github.com/bitshares/bitshares-core/issues/1573`
	`227`	`+ FC_ASSERT( fc::raw::pack_size( trx ) < (1024 * 1024), "Transaction exceeds maximum transaction size." );`
`226`	`228`	`processed_transaction result;`
`227`	`229`	`detail::with_skip_flags( *this, skip, [&]()`
`228`	`230`	`{`