Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference actions by commit SHA #135

Closed
gabibguti opened this issue Aug 23, 2023 · 1 comment · Fixed by #136
Closed

Reference actions by commit SHA #135

gabibguti opened this issue Aug 23, 2023 · 1 comment · Fixed by #136

Comments

@gabibguti
Copy link
Contributor

Referencing actions by commit SHA in GitHub workflows guarantees you are using an immutable version. Actions referenced by tags and branches are more vulnerable to attacks, such as the tag being moved to a malicious commit or a malicious commit being pushed to the branch.

Although there are pros and cons for each reference, GitHub understands using commit SHAs is more reliable, as does Scorecard security tool.

I recently recommended #126 and, like that change, this one also a security good-practice. If you agree, we can update, for example, actions/setup-go@v4 to actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe followed by a comment # v4.1.0 to keep the version readable and I can support you by opening a PR.

Additional Context

Hi! I'm Gabriela and I work on behalf of Google and the OpenSSF suggesting supply-chain security changes :)

@lemire
Copy link
Member

lemire commented Aug 24, 2023

Please do @gabibguti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants