Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.yml
andREADME.md
is updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
It's probably a good idea to disable git GC to make step run times more deterministic. See the investigation details section for numbers.
Changes
Run
git config gc.auto 0
before the fetch commands.Investigation details
I created a Go benchmark for measuring the difference. This test case fetches the https://github.com/androidx/androidx repo main branch, which has quite a long history. It's not a super scientific test as it includes a lot of network calls, but at least it shows that this change doesn't slow us down:
The reason I'm not including the benchmark in this PR is that it required uncommenting a few parts of the step code to make it work.
Decisions