Skip to content

Commit 9b109ea

Browse files
committed
remove lodash calls from base58 code
1 parent 36a406c commit 9b109ea

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

packages/bitcore-lib-cash/lib/encoding/base58.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
var _ = require('lodash');
43
var bs58 = require('bs58');
54
var buffer = require('buffer');
65

@@ -26,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
2625
if (buffer.Buffer.isBuffer(chars)) {
2726
chars = chars.toString();
2827
}
29-
return _.every(_.map(chars, function(char) { return ALPHABET.includes(char); }));
28+
return [...chars].every(c => ALPHABET.includes(c));
3029
};
3130

3231
Base58.prototype.set = function(obj) {

packages/bitcore-lib-doge/lib/encoding/base58.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
var _ = require('lodash');
43
var bs58 = require('bs58');
54
var buffer = require('buffer');
65

@@ -26,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
2625
if (buffer.Buffer.isBuffer(chars)) {
2726
chars = chars.toString();
2827
}
29-
return _.every(_.map(chars, function(char) { return (ALPHABET.includes(char)) }));
28+
return [...chars].every(c => ALPHABET.includes(c));
3029
};
3130

3231
Base58.prototype.set = function(obj) {

packages/bitcore-lib-ltc/lib/encoding/base58.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
var _ = require('lodash');
43
var bs58 = require('bs58');
54

65
var ALPHABET = '123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz'.split('');
@@ -25,7 +24,7 @@ Base58.validCharacters = function validCharacters(chars) {
2524
if (Buffer.isBuffer(chars)) {
2625
chars = chars.toString();
2726
}
28-
return _.every(_.map(chars, function(char) { return (ALPHABET.includes(char)) }));
27+
return [...chars].every(c => ALPHABET.includes(c));
2928
};
3029

3130
Base58.prototype.set = function(obj) {

packages/bitcore-lib/lib/encoding/base58.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22

3-
var _ = require('lodash');
43
var bs58 = require('bs58');
54
var buffer = require('buffer');
65

@@ -26,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
2625
if (buffer.Buffer.isBuffer(chars)) {
2726
chars = chars.toString();
2827
}
29-
return _.every(_.map(chars, function(char) { return ALPHABET.includes(char); }));
28+
return [...chars].every(c => ALPHABET.includes(c));
3029
};
3130

3231
Base58.prototype.set = function(obj) {

0 commit comments

Comments
 (0)