-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactComponent.propTypes is undefined when dynamically inject the react build js #5
Comments
Thanks! Just to make sure I am understanding what is happening and how to test it ... you are dynamically addicting React after this library is installed? |
Looks like I am encountering this as well. |
Oh I see, this package is perhaps assuming we are using propTypes, now https://www.npmjs.com/package/prop-types. |
Re-opened #6 |
Ah, so ReactComponent doesn't always have propTypes. Thanks! |
I think I had a similar issue and solved it like this:
|
We adjusted the logic in #50 to allow an alternate prop definition besides propTypes. We cannot current get around the need for a minimal props definition at runtime, however. |
Fix this by adding null check.
The text was updated successfully, but these errors were encountered: