Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapters should be separate from FuncUnit #81

Open
alexisabril opened this issue Aug 14, 2014 · 4 comments
Open

Adapters should be separate from FuncUnit #81

alexisabril opened this issue Aug 14, 2014 · 4 comments

Comments

@alexisabril
Copy link
Contributor

Jasmine has changed it's approach to async execution in v2. This modifies the jasmine-funcunit adapter to take a done() callback into account, as opposed to waitsFor(). This illustrates the need to have independent, versioned adapters so that we can support FuncUnit with any version of QUnit, Jasmine or Mocha without re-versioning FuncUnit itself.

@justinbmeyer
Copy link
Member

I'm not sure what you mean exactly. How would you structure these adapters?

@alexisabril
Copy link
Contributor Author

I'm thinking funcunit-jasmine, funcunit-qunit and funcunit-mocha respectively. I'm not 100% on how we should setup the dist though.

@justinbmeyer
Copy link
Member

The dist should include all of them and be able to feature detect/version through each one.

@jitcoder
Copy link

jitcoder commented May 6, 2015

after hours of pain and suffering (PhantomJS, Jasmine, FuncUnit) I finally noticed that FuncUnit expects pre-jasmine 2.0 sync goodies. I agree 100% about the adapters being separate. Has this been implemented? I don't want to use an older version of jasmine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants