Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum call stack size exceeded when calling can.Map.List.replace with big array #779

Closed
janza opened this issue Mar 12, 2014 · 2 comments

Comments

@janza
Copy link
Contributor

janza commented Mar 12, 2014

Try the following in chrome:

var a = [], l = new can.Map.List([]);
for(var i=0; i<50000; i++){
    a.push(1);
}
l.replace(a);
@alexisabril
Copy link
Contributor

This is a limit on using splice.apply with an object(instance of can.List) as the context. Example breaking in Chrome 43.0.2357.132(Mac) without CanJS: http://jsbin.com/siqene/edit?js,console

With a simple array, there's a much higher threshold, so there may be a performance gain to be made here.

@daffl
Copy link
Contributor

daffl commented Oct 22, 2015

Closing since I don't think there is much we can do.

@daffl daffl closed this as completed Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants