[bitnami/flux] Fix incorrect argument mapping and add missing events-addr argument #30523
+15
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses two key issues in the current Bitnami Helm chart for FluxCD:
1. Fix Argument Mapping for Notification Controller
events-addr
: The address where the controller listens for events from other controllers (e.g.,helm-controller
,kustomize-controller
). Events received on this address trigger Alert objects.receiverAddr
: The address where the controller listens for webhooks from external sources (e.g., Git repositories). Requests sent to this address trigger Receiver objects.receiver
key maps toreceiverAddr
, which is correct.webhook
key is incorrectly mapped toevents-addr
.webhook
key would expect it to configure the webhook listener (receiverAddr
), but instead, it configures the event listener (events-addr
).receiver
key, which users would expect to configure the event listener (events-addr
), instead configures the webhook listener (receiverAddr
).webhook
key →receiverAddr
(Webhook listener).receiver
key →events-addr
(Event listener).2. Add Missing
events-addr
Argument for Other Controllersevents-addr
argument was not initialized for the following controllers:helm-controller
kustomize-controller
source-controller
image-automation-controller
image-reflector-controller
events-addr
argument for these controllers, with its value set to the address of the Notification Controller's service.Impact
events-addr
argument.Testing
events-addr
and webhooks viareceiverAddr
.events-addr
argument to communicate with the Notification Controller.Checklist
webhook
andreceiver
keys in the Notification Controller.events-addr
argument to the relevant controllers.Notes
These changes ensure that all FluxCD controllers are correctly configured for communication and align with the expected behavior of the Notification Controller.