[bitnami/keycloak] KEYCLOAK_HOSTNAME present even if KEYCLOAK_PROXY_HEADERS is set #30368
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the config map should not be set. Signed-off-by: Renaud Demarneffe <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Thanks a lot @RDemarneffe for your contribution.
I've just left a comment. Maybe I didn't understand the issue but I think the condition you set is almost the opposite. BTW Could you provide an scenario to reproduce the issue and test your changes?
# Conflicts: # bitnami/keycloak/CHANGELOG.md # bitnami/keycloak/Chart.yaml
Signed-off-by: Renaud Demarneffe <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Thanks a lot @RDemarneffe for your contribution!
I reproduced the issue you mentioned in #30368 and how these changes fix it. But I have a couple of doubts below, Could you give them a glance?
Signed-off-by: Renaud Demarneffe <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When the helm proxyHeaders variable is set, the KEYCLOAK_HOSTNAME into the config map should not be set.
Benefits
Improve chart to respect the keycloak documentation.
Possible drawbacks
None
Applicable issues
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm