feat: manage the secrets annotated to be managed by the controller #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmik
reviewed
Dec 9, 2019
mkmik
reviewed
Dec 10, 2019
|
Integration tests are failing. make integrationtest |
mashail
commented
Dec 10, 2019
| @@ -253,6 +257,7 @@ func (c *Controller) unseal(key string) error { | |||
| secret.Data = newSecret.Data | |||
| secret.Type = newSecret.Type | |||
| secret.ObjectMeta.Annotations = newSecret.ObjectMeta.Annotations | |||
| secret.ObjectMeta.OwnerReferences = newSecret.ObjectMeta.OwnerReferences | |||
There was a problem hiding this comment.
@mkmik I am thinking to append the OwnerRefernces and as it's now being overwritten. What do you think?
| }, Timeout, PollingInterval).Should(WithTransform(getData, Equal(expected))) | ||
| Eventually(func() (*v1.Secret, error) { | ||
| return c.Secrets(ns).Get(secretName, metav1.GetOptions{}) | ||
| }, Timeout, PollingInterval).Should(WithTransform(getFirstOwnerName, Equal(ss.GetName()))) |
There was a problem hiding this comment.
@mkmik can you please help this check is failing as there are no owners. I tried it manually and it's updating the existing secret owners with SealedSecret as one among theme
Co-Authored-By: Marko Mikulicic <[email protected]>
mkmik
reviewed
Dec 11, 2019
Co-Authored-By: Marko Mikulicic <[email protected]>
|
Yes I did I told it's failing I don't what's the issue with my assertion. But let me check try second time. And I will get back to you. if I needed a help |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 13, 2019
331: feat: manage the secrets annotated to be managed by the controller r=mkmik a=malmuzaini Co-authored-by: Mashail Almuzaini <[email protected]>
Build succeeded |
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.