fix: socket variable testing for undefined (#1726)

* fix: socket variable testing for undefined Avoid issue where socket event was not triggered and local socket vraible is not defined. This issue is reproducible only using deno. * chore: made socket test capture simpler Only controls the execution of the section that uses socket. * Update src/index.js Co-authored-by: Linus Unnebäck <[email protected]> * Update index.js --------- Co-authored-by: Linus Unnebäck <[email protected]> Co-authored-by: Jimmy Wärting <[email protected]>
node-fetch · Jun 29, 2023 · 8bc3a7c · 8bc3a7c
1 parent afb36f6
commit 8bc3a7c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -362,8 +362,11 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
 		const {headers} = response;
 		if (headers['transfer-encoding'] === 'chunked' && !headers['content-length']) {
 			response.once('close', hadError => {
-				// if a data listener is still present we didn't end cleanly
-				const hasDataListener = socket.listenerCount('data') > 0;
+				// tests for socket presence, as in some situations the
+				// the 'socket' event is not triggered for the request
+				// (happens in deno), avoids `TypeError`
+        // if a data listener is still present we didn't end cleanly
+				const hasDataListener = socket && socket.listenerCount('data') > 0;
 
 				if (hasDataListener && !hadError) {
 					const err = new Error('Premature close');