Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDepositAddress: Add missing LNX invoice field #53

Open
1 of 4 tasks
juscamarena opened this issue Feb 12, 2020 · 2 comments
Open
1 of 4 tasks

getDepositAddress: Add missing LNX invoice field #53

juscamarena opened this issue Feb 12, 2020 · 2 comments

Comments

@juscamarena
Copy link

juscamarena commented Feb 12, 2020

Issue type

  • bug
  • missing functionality
  • performance
  • feature request

Brief description

LNX lighting deposit generation returns the id of the payment and does not show the lightning invoice.

Steps to reproduce

generateDeposit

rest.getDepositAddress({
wallet: 'exchange',
method: 'lnx',
currency: 'lnx',
amount,
opRenew: 1, // always 1 cannot reuse ln invoices
});

Additional Notes:

The public api for the frontend returns the field set as invoice:

Example:

{"worked":true,"message":null,"invoice":"lnbc20m1p0yg0depp5dncaf5s4eg4z0dwg5xpaet4568yr6umgtgyylwlhhtzl7280jptqdp5xu6xxetzxdjnwe3kxgek2wpevyckzcek8p3nvvf3x43rzv33xa3scqzpgxqzjcadpzulmsa0s0sm394934ws62hx2ggg7mjtunr4yrgjfxpf0tewk5mw82le8st2yzrg5fpxh9574gkrwq7x6rphp90klm44patfx2jtsq0jw0m0","address":"74ceb3e7f623e89a1ac68c6115b1217c"}

Lightning invoices also expire so not sure limiting opRenew is a good idea.

@juscamarena juscamarena changed the title Add missing LNX invoice field getDepositAddress: Add missing LNX invoice field Feb 12, 2020
@JacobPlaster
Copy link
Contributor

Hi, generating a lightning invoice is not part of the getDepositAddress feature set since it requires a completely different API call. Currently, the UI uses the endpoint https://www.bitfinex.com/deposits/_invoice but this endpoint is not public yet so there is no documentation available

@juscamarena
Copy link
Author

Ah so it will be in another endpoint?

Great, I've been https://www.bitfinex.com/deposits/_invoice just fine until then thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants