Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test is failing with 29 errors #1

Closed
sandipmgiri opened this issue Aug 6, 2018 · 1 comment
Closed

npm test is failing with 29 errors #1

sandipmgiri opened this issue Aug 6, 2018 · 1 comment

Comments

@sandipmgiri
Copy link

Build passed successfully , however test command was failing with 29 errors :

$ npm test

> [email protected] test /jline
> jshint bin/ lib/ && ./test/_all.sh

bin/csv.js: line 12, col 25, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/csv.js: line 28, col 15, Missing semicolon.
bin/csv.js: line 31, col 38, Missing semicolon.
bin/csv.js: line 32, col 11, Missing semicolon.

bin/foreach.js: line 36, col 43, Did you mean to return a conditional instead of an assignment?

bin/join_left.js: line 5, col 1, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
bin/join_left.js: line 15, col 36, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 15, col 80, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 18, col 19, 'template literal syntax' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 19, col 33, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 21, col 29, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 22, col 13, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
bin/join_left.js: line 23, col 13, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
bin/join_left.js: line 24, col 13, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
bin/join_left.js: line 27, col 24, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 28, col 21, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 28, col 32, Missing semicolon.
bin/join_left.js: line 29, col 25, Missing semicolon.
bin/join_left.js: line 36, col 23, 'template literal syntax' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 42, col 33, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 43, col 9, 'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
bin/join_left.js: line 45, col 27, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 46, col 24, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 47, col 21, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 48, col 25, Missing semicolon.
bin/join_left.js: line 57, col 46, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 61, col 47, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 61, col 94, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
bin/join_left.js: line 61, col 134, 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

29 errors
npm ERR! Test failed.  See above for more details.

22 errors got resolved after adding , {"esversion": 6} in .jshintrc (found solution - https://stackoverflow.com/questions/27441803/why-does-jshint-throw-a-warning-if-i-am-using-const/37472928#37472928)

Still 7 errors were getting :

$ npm test
> [email protected] test /jline
> jshint bin/ lib/ && ./test/_all.sh

bin/csv.js: line 28, col 15, Missing semicolon.
bin/csv.js: line 31, col 38, Missing semicolon.
bin/csv.js: line 32, col 11, Missing semicolon.

bin/foreach.js: line 36, col 43, Did you mean to return a conditional instead of an assignment?

bin/join_left.js: line 28, col 32, Missing semicolon.
bin/join_left.js: line 29, col 25, Missing semicolon.
bin/join_left.js: line 48, col 25, Missing semicolon.

7 errors
npm ERR! Test failed.  See above for more details.

Added missing semicolons and brackets , now all the tests are passing.

Could you please make the changes as suggested above?

@bitdivine
Copy link
Owner

bitdivine commented Feb 27, 2021

Thank you for the report. Apologies for the delay in responding. This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants