Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Level Commander does not run trajectories with ID greater than or equal to 10. #1393

Closed
Acoliver102 opened this issue Jul 17, 2024 · 4 comments · Fixed by #1394
Closed
Labels

Comments

@Acoliver102
Copy link
Contributor

The documentation states that the CF is capable of calling up to 31 trajectories, but this bug is preventing the drone from using more than 10. From my testing, this does not appear to be an issue with the size of the memory on the CF, seeing as it persists even though the trajectory definition is being sent without any offset and when only one trajectory is being written to the drone.

Recreation Steps:

For arbitrary ID values between 1 and 9, the code behaves as expected.

Expected behavior: Drone takes off, performs the figure 8 trajectory, and then lands.
Actual behavior: Drone takes off, waits for the duration of the figure 8 trajectory, and then lands.

Tested on:

  • cfclient 2024.7.1 / cflib 0.1.26
  • cfclient 2023.6 / cflib 0.1.23

CF Firmware version is Firmware: ec6a792 (CLEAN). The issue also persists when using Firmware: 182455b (CLEAN).

@Acoliver102
Copy link
Contributor Author

The 2nd Firmware version is forked from the May 2024 version of the CF Firmware, for those curious.

@knmcguire knmcguire added the bug label Jul 22, 2024
@knmcguire
Copy link
Member

Thanks for notifying us on this! This seems to be a clear bug but I do think that not many upload as many trajectories as you have tried:)

Currently we are a bit low on staff at the office but I've marked this for our next triage for hopefully after the summer. If you happen to find the fix, feel free to make a PR and link to this issue.

@Acoliver102
Copy link
Contributor Author

Acoliver102 commented Jul 22, 2024

@knmcguire

Found the issue - constant value that caps trajectory limits was set to 10. Changing it to 31 fixes the issue - system behaves as expected. Can upload and run up to 31 trajectories at once. Pull request is up at #1394.

@knmcguire
Copy link
Member

closed with #1394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants