Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters not updated in UI #657

Closed
krichardsson opened this issue Feb 20, 2023 · 4 comments
Closed

Parameters not updated in UI #657

krichardsson opened this issue Feb 20, 2023 · 4 comments

Comments

@krichardsson
Copy link
Contributor

Parameters that are updated from the firmware pushes the new value to the client. The problem is that the value in the parameter tab is not updated.

How to reproduce:

  1. Create a firmware app that sets a parameter
  2. Open the client and connect to the Crazyflie
  3. Open the parameter tab and look at the value of the parameter
  4. Let the firmware app update the parameter
  5. Observe the parameter value in the parameter tab

Observed behavior:
The value in the parameter tab is not updated

Expected behavior:
The value in the parameter tab is updated

@knmcguire
Copy link
Member

This might be fixed already with this PR in the crazyflie? bitcraze/crazyflie-firmware#1193

@knmcguire knmcguire added this to the next-release milestone Oct 12, 2023
@knmcguire
Copy link
Member

We will try this out if this is still an issue or not. It might have been fixed but we can't be sure.

@krichardsson
Copy link
Contributor Author

The problem is not in the client, but both in the firmware and the python lib. The firmware was producing bad packets both for int and float parameter updates originating in the Crazyflie. The lib was completely missing functionality for handling parameter updates from the Crazyflie!

The client was OK already, parameter values are updated live in the list, but not in the section where new parameter values are set.

@knmcguire
Copy link
Member

tested! and this is fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants