-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signet support #1820
Comments
Adding signet to this library will only temporarily fix the issue of how networks are handled by galoy.
At each point where It would be better to gather everything into one place in their codebase, import the existing network objects from bitcoinjs-lib, add whichever networks are missing + create any aliases needed. Because they did not do this, and the code was written with the implicit misunderstanding that "bitcoinjs-lib already has signet as a default network object" which causes the problem. That being said, I am not opposed to adding signet as a named network here. It's basically like another testnet, so having it as a named network should be fine. Either way you will need galoy to update to a new version, so why not fix their network usage on a more fundamental level instead? ie. Remove assumptions from the code instead of making the library mold to the assumptions? To make my concerns easier to understand, I will pose this rhetorical question: "Every time galoy adds some new network (signet2 or signet3 or signetTheEmpireStrikesBack) are we going to be required to add that network as well?" The fact that I have to ask that question points to there being a fundamental flaw in the way galoy is handling the network object usage, and I think the issue should be fixed there first. Again, I am not against adding signet, though. |
we could indeed have a proper mapping from our domain object to |
PR to have proper mapping on the galoy side: GaloyMoney/blink@b474369 I guess we can run with this for now |
I used bitcoinjs-lib with signet with no problem. |
I agree that signet and testnet are almost exactly the same at the application level. |
signet support is missing from the library
(this is generating typescript error here: https://github.com/GaloyMoney/galoy/blob/main/src/domain/bitcoin/onchain/tx-decoder.ts @openoms @dolcalmi)
The text was updated successfully, but these errors were encountered: