Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo features #1017

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Jun 26, 2023

Description

The following commands failed on master:

$ cargo build -p bdk_esplora
$ cargo build -p bdk_electrum

This PR introduces the following fixes:

  • bdk_chain/std should also enable miniscript/std
  • use the version of hashbrown that bitcoin and miniscript uses

Notes to the reviewers

Changelog notice

  • Change the version of hashbrown to 0.11 (the version that bitcoin and miniscript uses).
  • Fix the std feature flags for bdk_chain.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

* [ ] This pull request breaks the existing API
* [ ] I've added tests to reproduce the issue which are now passing
* [ ] I'm linking the issue being fixed by this PR

@notmandatory notmandatory added this to the 1.0.0-alpha.1 milestone Jun 26, 2023
@evanlinjin evanlinjin force-pushed the fix_cargo_features branch 2 times, most recently from 72e1e81 to 89e0e90 Compare June 26, 2023 02:56
* `bdk_chain/std` should also enable `miniscript/std`
* use the version of `hashbrown` that `bitcoin` and `miniscript` is
  using
@evanlinjin evanlinjin force-pushed the fix_cargo_features branch from 89e0e90 to 26ade11 Compare June 26, 2023 03:02
@evanlinjin evanlinjin requested a review from notmandatory June 26, 2023 03:06
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 26ade11

@notmandatory notmandatory merged commit 26ade11 into bitcoindevkit:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants