ci fixes

Author: kwsantiago

.github/workflows/cont_integration.yml

@@ -166,30 +166,3 @@ jobs:
           name: Clippy Results
           args: --all-features --all-targets -- -D warnings
 
-  build-examples:
-    needs: prepare
-    name: Build & Test Examples
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        example-dir:
-          - example_cli
-          - example_bitcoind_rpc_polling
-          - example_electrum
-          - example_esplora
-    steps:
-      - name: checkout
-        uses: actions/checkout@v4
-        with:
-          persist-credentials: false
-      - name: Install Rust toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: ${{ needs.prepare.outputs.rust_version }}
-          override: true
-          profile: minimal
-      - name: Rust Cache
-        uses: Swatinem/[email protected]
-      - name: Build
-        working-directory: examples/${{ matrix.example-dir }}
-        run: cargo build

crates/chain/src/indexed_tx_graph.rs

@@ -81,7 +81,7 @@ where
     /// # Example
     ///
     /// ```
-    /// use bdk_chain::{IndexedTxGraph, keychain_txout::KeychainTxOutIndex, BlockId};
+    /// use bdk_chain::{keychain_txout::KeychainTxOutIndex, BlockId, IndexedTxGraph};
     ///
     /// let index = KeychainTxOutIndex::<&str>::new(10, true);
     /// let graph = IndexedTxGraph::<BlockId, _>::new(index);

crates/chain/src/tx_graph.rs

@@ -1268,19 +1268,32 @@ impl<A: Anchor> TxGraph<A> {
     /// # Example
     ///
     /// ```
-    /// use bdk_chain::{tx_graph::TxGraph, BlockId, CanonicalizationParams};
     /// use bdk_chain::local_chain::LocalChain;
-    /// use bitcoin::{OutPoint, TxOut, Amount};
+    /// use bdk_chain::{tx_graph::TxGraph, BlockId, CanonicalizationParams};
+    /// use bitcoin::{Amount, OutPoint, TxOut};
     /// use std::sync::Arc;
     ///
     /// let mut graph = TxGraph::<BlockId>::default();
-    /// let chain = LocalChain::from_blocks([
-    ///     (0, bitcoin::constants::genesis_block(bitcoin::Network::Bitcoin).block_hash())
-    /// ].into_iter().collect()).unwrap();
+    /// let chain = LocalChain::from_blocks(
+    ///     [(
+    ///         0,
+    ///         bitcoin::constants::genesis_block(bitcoin::Network::Bitcoin).block_hash(),
+    ///     )]
+    ///     .into_iter()
+    ///     .collect(),
+    /// )
+    /// .unwrap();
     ///
     /// // Get unspent outputs
     /// let outpoints = vec![(0, OutPoint::default())];
-    /// let utxos: Vec<_> = graph.filter_chain_unspents(&chain, chain.tip().block_id(), CanonicalizationParams::default(), outpoints).collect();
+    /// let utxos: Vec<_> = graph
+    ///     .filter_chain_unspents(
+    ///         &chain,
+    ///         chain.tip().block_id(),
+    ///         CanonicalizationParams::default(),
+    ///         outpoints,
+    ///     )
+    ///     .collect();
     /// ```
     ///
     /// [`try_filter_chain_unspents`]: Self::try_filter_chain_unspents
@@ -1354,17 +1367,29 @@ impl<A: Anchor> TxGraph<A> {
     /// # Example
     ///
     /// ```
-    /// use bdk_chain::{tx_graph::TxGraph, Balance, BlockId, CanonicalizationParams};
     /// use bdk_chain::local_chain::LocalChain;
+    /// use bdk_chain::{tx_graph::TxGraph, Balance, BlockId, CanonicalizationParams};
     /// use bitcoin::OutPoint;
     ///
     /// let graph = TxGraph::<BlockId>::default();
-    /// let chain = LocalChain::from_blocks([
-    ///     (0, bitcoin::constants::genesis_block(bitcoin::Network::Bitcoin).block_hash())
-    /// ].into_iter().collect()).unwrap();
+    /// let chain = LocalChain::from_blocks(
+    ///     [(
+    ///         0,
+    ///         bitcoin::constants::genesis_block(bitcoin::Network::Bitcoin).block_hash(),
+    ///     )]
+    ///     .into_iter()
+    ///     .collect(),
+    /// )
+    /// .unwrap();
     ///
     /// let outpoints = vec![(0, OutPoint::default())];
-    /// let balance = graph.balance(&chain, chain.tip().block_id(), CanonicalizationParams::default(), outpoints, |_, _| true);
+    /// let balance = graph.balance(
+    ///     &chain,
+    ///     chain.tip().block_id(),
+    ///     CanonicalizationParams::default(),
+    ///     outpoints,
+    ///     |_, _| true,
+    /// );
     /// ```
     ///
     /// [`try_balance`]: Self::try_balance

crates/electrum/src/bdk_electrum_client.rs

@@ -32,7 +32,7 @@ impl<E: ElectrumApi> BdkElectrumClient<E> {
     /// # Example
     ///
     /// ```no_run
-    /// use bdk_electrum::{BdkElectrumClient, electrum_client};
+    /// use bdk_electrum::{electrum_client, BdkElectrumClient};
     ///
     /// let client = electrum_client::Client::new("ssl://electrum.blockstream.info:50002")?;
     /// let bdk_client = BdkElectrumClient::new(client);
@@ -103,14 +103,18 @@ impl<E: ElectrumApi> BdkElectrumClient<E> {
     /// # Example
     ///
     /// ```no_run
+    /// use bdk_core::{spk_client::FullScanRequest, BlockId, CheckPoint};
     /// use bdk_electrum::BdkElectrumClient;
-    /// use bdk_core::spk_client::FullScanRequest;
     /// # use bdk_electrum::electrum_client;
+    /// # use electrum_client::bitcoin::{constants, Network};
     ///
     /// # let client = electrum_client::Client::new("ssl://electrum.blockstream.info:50002")?;
     /// # let bdk_client = BdkElectrumClient::new(client);
     /// let request = FullScanRequest::<&str>::builder()
-    ///     .chain_tip(Default::default())
+    ///     .chain_tip(CheckPoint::new(BlockId {
+    ///         height: 0,
+    ///         hash: constants::genesis_block(Network::Bitcoin).block_hash(),
+    ///     }))
     ///     .build();
     ///
     /// let response = bdk_client.full_scan(request, 10, 50, false)?;
@@ -203,9 +207,9 @@ impl<E: ElectrumApi> BdkElectrumClient<E> {
     /// # Example
     ///
     /// ```no_run
-    /// use bdk_electrum::BdkElectrumClient;
-    /// use bdk_core::spk_client::SyncRequest;
     /// use bdk_core::bitcoin::ScriptBuf;
+    /// use bdk_core::spk_client::SyncRequest;
+    /// use bdk_electrum::BdkElectrumClient;
     /// # use bdk_electrum::electrum_client;
     ///
     /// # let client = electrum_client::Client::new("ssl://electrum.blockstream.info:50002")?;

crates/esplora/src/blocking_ext.rs

@@ -29,15 +29,18 @@ pub trait EsploraExt {
     /// # Example
     ///
     /// ```no_run
-    /// use bdk_esplora::{EsploraExt, esplora_client};
+    /// use bdk_core::bitcoin::{constants, Network};
     /// use bdk_core::spk_client::FullScanRequest;
-    /// use bdk_core::bitcoin::Network;
+    /// use bdk_core::{BlockId, CheckPoint};
+    /// use bdk_esplora::{esplora_client, EsploraExt};
     ///
-    /// let client = esplora_client::Builder::new("https://blockstream.info/api")
-    ///     .build_blocking();
+    /// let client = esplora_client::Builder::new("https://blockstream.info/api").build_blocking();
     ///
     /// let request = FullScanRequest::<&str>::builder()
-    ///     .chain_tip(Default::default())
+    ///     .chain_tip(CheckPoint::new(BlockId {
+    ///         height: 0,
+    ///         hash: constants::genesis_block(Network::Bitcoin).block_hash(),
+    ///     }))
     ///     .build();
     ///
     /// let response = client.full_scan(request, 10, 5)?;