Update to bdk v0.26.0 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey looks like you need do to a |
rajarshimaitra
force-pushed
the
update_bdk_v0.26
branch
from
2e2e0e1 to
c29442d
Compare
|
Ah my bad.. Updated.. |
24 tasks
|
I updated bdk-reserves "update_bdk_026" branch with bdk rc.2. |
notmandatory
reviewed
Jan 3, 2023
src/utils.rs
Outdated
| @@ -390,6 +390,7 @@ pub(crate) fn new_blockchain( | |||
| retry: wallet_opts.proxy_opts.retries, | |||
| timeout: wallet_opts.electrum_opts.timeout, | |||
| stop_gap: wallet_opts.electrum_opts.stop_gap, | |||
| validate_domain: false, | |||
There was a problem hiding this comment.
This should be true since that's the default prior to adding the option.
Suggested change
| validate_domain: false, | |
| validate_domain: true, |
There was a problem hiding this comment.
ACK.. Missed that thought..
notmandatory
force-pushed
the
update_bdk_v0.26
branch
2 times, most recently
from
41c8ea5 to
8db5ef3
Compare
notmandatory
force-pushed
the
update_bdk_v0.26
branch
from
8db5ef3 to
8948fc1
Compare
notmandatory
force-pushed
the
update_bdk_v0.26
branch
from
8948fc1 to
52dd87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to bdk v0.26.0
Notes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing