Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log level in cli #1

Closed
RCasatta opened this issue Dec 18, 2020 · 1 comment · Fixed by #2
Closed

log level in cli #1

RCasatta opened this issue Dec 18, 2020 · 1 comment · Fixed by #2

Comments

@RCasatta
Copy link
Member

After the introduction of the --log_level cli parameter, we lost the ability to filter logs by package making it unusable for log levels like debug or more granular (because there is too much output from package like rustls and sled).

example

RUST_LOG=debug,sled=info,rustls=info cargo run ...

I think we should either:

  • remove --log_level parameter
  • if possible accept in --log_level the same format supported in RUST_LOG and even allow RUST_LOG to work in alternative (I missed the --log_levelupdate and I started trying to use RUST_LOG automatically which is the standard in the rust ecosystem and I was surprised it had no effect)
@eupn
Copy link
Contributor

eupn commented Dec 18, 2020

I think it makes sense to only use RUST_LOG for anything logging-related. It's an industry standard and a lot of rustaceans expect this env var to work out of the box.

@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk Dec 18, 2020
@notmandatory notmandatory mentioned this issue Dec 18, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants