Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenSSL benchmarks? #736

Closed
real-or-random opened this issue Apr 9, 2020 · 3 comments
Closed

Remove OpenSSL benchmarks? #736

real-or-random opened this issue Apr 9, 2020 · 3 comments

Comments

@real-or-random
Copy link
Contributor

I think OpenSSL is useful for cross-testing (see #635) but I find the benchmark are annoying:

I think the benchmarks were useful in the early days of this library to demonstrate that it outperforms OpenSSL but this not necessary anymore.

Do people agree that we should remove them?
@elichai
Copy link
Contributor

elichai commented Apr 9, 2020

I'm fine with it.
But I think I'll look into implementing #716 this week to completely remote openssl

@elichai elichai mentioned this issue Apr 12, 2020
Open
@real-or-random real-or-random mentioned this issue Sep 28, 2021
Merged
@sipa
Copy link
Contributor

sipa commented Sep 28, 2021

ACK (independent of whether we also get rid of the OpenSSL tests or not)

@real-or-random
Copy link
Contributor Author

resolved by #983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sipa @real-or-random @elichai