Change EventLoop::m_task_set to not use boost

EventLoop::m_task_set was unnecessary defined as
boost::optional<kj::TaskSet> because it is always initialized.
Thus, a bare kj::TaskSet suffices.

Author: vasild

include/mp/proxy-io.h

@@ -199,7 +199,7 @@ class EventLoop
     LoggingErrorHandler m_error_handler{*this};
 
     //! Capnp list of pending promises.
-    boost::optional<kj::TaskSet> m_task_set;
+    kj::TaskSet m_task_set;
 
     //! List of connections.
     std::list<Connection> m_incoming_connections;
@@ -310,7 +310,7 @@ class Connection
         // to the EventLoop TaskSet to avoid "Promise callback destroyed itself"
         // error in cases where f deletes this Connection object.
         m_on_disconnect.add(m_network.onDisconnect().then(
-            kj::mvCapture(f, [this](F&& f) { m_loop.m_task_set->add(kj::evalLater(kj::mv(f))); })));
+            kj::mvCapture(f, [this](F&& f) { m_loop.m_task_set.add(kj::evalLater(kj::mv(f))); })));
     }
 
     EventLoop& m_loop;
@@ -525,7 +525,7 @@ template <typename InitInterface, typename InitImpl>
 void _Listen(EventLoop& loop, kj::Own<kj::ConnectionReceiver>&& listener, InitImpl& init)
 {
     auto* ptr = listener.get();
-    loop.m_task_set->add(ptr->accept().then(kj::mvCapture(kj::mv(listener),
+    loop.m_task_set.add(ptr->accept().then(kj::mvCapture(kj::mv(listener),
         [&loop, &init](kj::Own<kj::ConnectionReceiver>&& listener, kj::Own<kj::AsyncIoStream>&& stream) {
             _Serve<InitInterface>(loop, kj::mv(stream), init);
             _Listen<InitInterface>(loop, kj::mv(listener), init);

include/mp/proxy-types.h

@@ -1358,7 +1358,7 @@ void clientInvoke(ProxyClient& proxy_client, const GetRequest& get_request, Fiel
             << "{" << invoke_context.thread_context.thread_name << "} IPC client send "
             << TypeName<typename Request::Params>() << " " << LogEscape(request.toString());
 
-        proxy_client.m_connection->m_loop.m_task_set->add(request.send().then(
+        proxy_client.m_connection->m_loop.m_task_set.add(request.send().then(
             [&](::capnp::Response<typename Request::Results>&& response) {
                 proxy_client.m_connection->m_loop.logPlain()
                     << "{" << invoke_context.thread_context.thread_name << "} IPC client recv "

src/mp/proxy.cpp

@@ -123,13 +123,16 @@ void Connection::addAsyncCleanup(std::function<void()> fn)
 }
 
 EventLoop::EventLoop(const char* exe_name, LogFn log_fn, void* context)
-    : m_exe_name(exe_name), m_io_context(kj::setupAsyncIo()), m_log_fn(std::move(log_fn)), m_context(context)
+    : m_exe_name(exe_name),
+      m_io_context(kj::setupAsyncIo()),
+      m_log_fn(std::move(log_fn)),
+      m_context(context),
+      m_task_set(m_error_handler)
 {
     int fds[2];
     KJ_SYSCALL(socketpair(AF_UNIX, SOCK_STREAM, 0, fds));
     m_wait_fd = fds[0];
     m_post_fd = fds[1];
-    m_task_set.emplace(m_error_handler);
 }
 
 EventLoop::~EventLoop()
@@ -170,7 +173,8 @@ void EventLoop::loop()
         m_cv.notify_all();
         if (m_num_clients == 0 && m_async_fns.empty()) {
             log() << "EventLoop::loop done, cancelling event listeners.";
-            m_task_set.reset();
+            using TaskSet = kj::TaskSet;
+            m_task_set.~TaskSet();
             log() << "EventLoop::loop bye.";
             break;
         }