clang-tidy: Suppress bitcoin-nontrivial-threadlocal error

ryanofsky · ryanofsky · commit a5bff37ad8f5 · 2025-05-15T11:24:01.000-04:00
/ci_container_base/include/mp/proxy-io.h:637:1: error: Variable with non-trivial destructor cannot be thread_local. [bitcoin-nontrivial-threadlocal,-warnings-as-errors] https://cirrus-ci.com/task/6187773452877824?logs=ci#L4720
diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h
@@ -634,7 +634,10 @@ void ListenConnections(EventLoop& loop, int fd, InitImpl& init)
     });
 }
 
-extern thread_local ThreadContext g_thread_context;
+extern thread_local ThreadContext g_thread_context; // NOLINT(bitcoin-nontrivial-threadlocal)
+// Silence nonstandard bitcoin tidy error "Variable with non-trivial destructor
+// cannot be thread_local" which should not be a problem on modern platforms, and
+// could lead to a small memory leak at worst on older ones.
 
 } // namespace mp
 

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,10 @@ void ListenConnections(EventLoop& loop, int fd, InitImpl& init)`
`634`	`634`	`});`
`635`	`635`	`}`
`636`	`636`
`637`		`-extern thread_local ThreadContext g_thread_context;`
	`637`	`+extern thread_local ThreadContext g_thread_context; // NOLINT(bitcoin-nontrivial-threadlocal)`
	`638`	`+// Silence nonstandard bitcoin tidy error "Variable with non-trivial destructor`
	`639`	`+// cannot be thread_local" which should not be a problem on modern platforms, and`
	`640`	`+// could lead to a small memory leak at worst on older ones.`
`638`	`641`
`639`	`642`	`} // namespace mp`
`640`	`643`