Replace send-to-self with dual send+receive entries #119

luke-jr · 2020-10-27T20:37:26Z

Makes the GUI transaction list more like the RPC, and IMO clearer in general.

As a side effect, this also fixes the GUI entries when a transaction is a net profit to us, but some inputs were also from us.

Originally bitcoin/bitcoin#15115

Has Concept ACKs from @*Empact @*jonasschnelli

promag · 2020-10-28T14:03:03Z

Concept ACK.

rebroad · 2021-03-29T10:57:42Z

@luke-jr what's the difference between raising a pull on this repository vs the bitcoin repository (as per your original 15115 pull request)? Sorry to ask this here but I'm unsure of where best to ask this.

hebasto · 2021-03-29T15:48:00Z

@rebroad

@luke-jr what's the difference between raising a pull on this repository vs the bitcoin repository (as per your original 15115 pull request)? Sorry to ask this here but I'm unsure of where best to ask this.

Moving into the GUI repo was requested explicitly by @fanquake.

maflcko · 2021-03-29T15:54:44Z

https://github.com/bitcoin-core/gui#development-process

src/qt/transactionrecord.cpp

Rspigler · 2021-07-06T23:01:19Z

Concept ACK

luke-jr · 2021-07-06T23:24:25Z

Rebased, ping @Rspigler @promag @Empact @jonasschnelli

Rspigler · 2021-07-07T03:58:57Z

Will build/test tomorrow

promag

Tested ACK and light code review aa744e4. Will post full review.

src/qt/transactionrecord.cpp

luke-jr · 2022-03-01T01:18:47Z

Rebased

Rspigler · 2022-03-02T02:17:49Z

Getting:

terminate called after throwing an instance of 'std::runtime_error'
what(): JSON value is not a string as expected
Aborted

when trying to open bitcoin-qt after compiling 2bb4e30.

Edit: I'm getting this on master too

hebasto · 2022-10-26T15:49:46Z

cc @achow101

achow101 · 2022-10-26T18:01:33Z

ACK 2bb4e30

Tested that it does indeed split up send-to-self payments.

hebasto

Tested 2bb4e30 on Ubuntu 22.04:

the master branch:
this PR:

hebasto

The first commit 880b151 fails to compile:

qt/transactionrecord.cpp: In static member function ‘static QList<TransactionRecord> TransactionRecord::decomposeTransaction(const interfaces::WalletTx&)’:
qt/transactionrecord.cpp:46:22: error: ‘ISMINE_NO’ was not declared in this scope; did you mean ‘wallet::ISMINE_NO’?
   46 |         fAllFromMe = ISMINE_NO;
      |                      ^~~~~~~~~
      |                      wallet::ISMINE_NO
In file included from qt/transactionrecord.cpp:10:
./wallet/ismine.h:42:5: note: ‘wallet::ISMINE_NO’ declared here
   42 |     ISMINE_NO         = 0,
      |     ^~~~~~~~~

hebasto · 2022-12-06T19:04:07Z

@luke-jr Are you planning to address #119 (review)?

DrahtBot · 2022-12-06T19:04:10Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto
Concept ACK	Rspigler
Stale ACK	promag, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

…g whether a transaction is a send or receive This changes behaviour (IMO for the better) in the case where some but not all inputs are from us, and the net amount is positive.

…ve pairs

If we didn't send it, it can't possibly be change, even if that's the key's purpose

…eceive

luke-jr · 2023-06-23T02:08:32Z

The first commit 880b151 fails to compile:

Fixed. Remaining commits are identical.

achow101 · 2023-07-14T23:12:49Z

src/qt/transactionrecord.cpp

-    {
-        isminetype fAllToMe = ISMINE_SPENDABLE;
+    if (fAllFromMe || !any_from_me) {
        for (const isminetype mine : wtx.txout_is_mine)


In f3fbe99 "GUI: TransactionRecord: Refactor to turn send-to-self into send+receive pairs"

This for loop seems to be duplicated from the one above. I think this could be refactored so that we don't need to duplicate this work?

hebasto

ACK 099dbe4.

Going to merge it, leaving further improvements for follow-ups.

…ve entries

Needed to support vector<bool> txout_is_change field added in bitcoin-core/gui#119

1c6fb04 Add support for vector<bool> serialization (Ryan Ofsky) Pull request description: Needed to support `vector<bool>` `txout_is_change` field added in bitcoin-core/gui#119 Top commit has no ACKs. Tree-SHA512: e7b87a6c52c09631c6effef66f79fa2954e8e5a6e4d17f348dc7295d6c3bd13da29922bd8802dcf5d566c2c72dcfed37da6889cc733850c8479bdd3113e2f6c9

maflcko changed the title ~~GUI: Replace send-to-self with dual send+receive entries~~ Replace send-to-self with dual send+receive entries Oct 28, 2020

DrahtBot added the Needs rebase label Dec 1, 2020

hebasto added the Wallet label Apr 19, 2021

jarolrod reviewed Jul 6, 2021

View reviewed changes

src/qt/transactionrecord.cpp Outdated Show resolved Hide resolved

luke-jr force-pushed the rm_send2self branch from 77a74aa to aa744e4 Compare July 6, 2021 23:23

DrahtBot removed the Needs rebase label Jul 6, 2021

promag reviewed Nov 9, 2021

View reviewed changes

src/qt/transactionrecord.cpp Outdated Show resolved Hide resolved

DrahtBot added the Needs rebase label Jan 11, 2022

luke-jr force-pushed the rm_send2self branch from aa744e4 to 2bb4e30 Compare March 1, 2022 01:18

DrahtBot removed the Needs rebase label Mar 1, 2022

hebasto requested a review from achow101 June 1, 2022 22:38

hebasto reviewed Oct 27, 2022

View reviewed changes

DrahtBot mentioned this pull request Jan 19, 2023

gui: Show labels for multiple SendToSelf addresses #698

Closed

luke-jr added 3 commits June 23, 2023 02:05

GUI: TransactionRecord: Use "any from me" as the criteria for decidin…

b9765ba

…g whether a transaction is a send or receive This changes behaviour (IMO for the better) in the case where some but not all inputs are from us, and the net amount is positive.

GUI: TransactionRecord: Refactor to turn send-to-self into send+recei…

f3fbe99

…ve pairs

GUI: Remove SendToSelf TransactionRecord type

71fbdb7

luke-jr added 2 commits June 23, 2023 02:06

Bugfix: Ignore ischange flag when we're not the sender

2d182f7

If we didn't send it, it can't possibly be change, even if that's the key's purpose

GUI: TransactionRecord: When time/index/etc match, sort send before r…

099dbe4

…eceive

luke-jr force-pushed the rm_send2self branch from 2bb4e30 to 099dbe4 Compare June 23, 2023 02:07

luke-jr requested review from hebasto, jarolrod and promag June 23, 2023 02:48

achow101 reviewed Jul 14, 2023

View reviewed changes

hebasto approved these changes Sep 22, 2023

View reviewed changes

DrahtBot requested a review from achow101 September 22, 2023 17:25

hebasto merged commit b000ed5 into bitcoin-core:master Sep 22, 2023

Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Sep 25, 2023

Merge bitcoin-core/gui#119: Replace send-to-self with dual send+recei…

591d9a4

…ve entries

bitcoin-core deleted a comment from indianfako Sep 26, 2023

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 26, 2023

Merge bitcoin-core/gui#119: Replace send-to-self with dual send+recei…

2fa8a37

ryanofsky added a commit to ryanofsky/libmultiprocess that referenced this pull request Sep 27, 2023

Add support for vector<bool> serialization

ebba56d

Needed to support vector<bool> txout_is_change field added in bitcoin-core/gui#119

ryanofsky mentioned this pull request Sep 27, 2023

Add support for vector<bool> serialization bitcoin-core/libmultiprocess#86

Merged

ryanofsky added a commit to ryanofsky/libmultiprocess that referenced this pull request Sep 27, 2023

Add support for vector<bool> serialization

1c6fb04

Needed to support vector<bool> txout_is_change field added in bitcoin-core/gui#119

bitcoin-core locked and limited conversation to collaborators Sep 25, 2024

Replace send-to-self with dual send+receive entries #119

Replace send-to-self with dual send+receive entries #119

Uh oh!

Conversation

luke-jr commented Oct 27, 2020 • edited by maflcko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented Oct 28, 2020

Uh oh!

rebroad commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Mar 29, 2021

Uh oh!

maflcko commented Mar 29, 2021

Uh oh!

Uh oh!

Rspigler commented Jul 6, 2021

Uh oh!

luke-jr commented Jul 6, 2021

Uh oh!

Rspigler commented Jul 7, 2021

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luke-jr commented Mar 1, 2022

Uh oh!

Rspigler commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Oct 26, 2022

Uh oh!

achow101 commented Oct 26, 2022

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Dec 6, 2022

Uh oh!

DrahtBot commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

luke-jr commented Jun 23, 2023

Uh oh!

achow101 Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

luke-jr commented Oct 27, 2020 •

edited by maflcko

Loading

rebroad commented Mar 29, 2021 •

edited

Loading

Rspigler commented Mar 2, 2022 •

edited

Loading

DrahtBot commented Dec 6, 2022 •

edited

Loading