GUI: Use translated external signer errors for messagebox text

luke-jr · hebasto · commit 170f3126f220 · 2023-03-31T12:22:05.000+01:00
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp
@@ -454,12 +454,14 @@ bool SendCoinsDialog::signWithExternalSigner(PartiallySignedTransaction& psbtx,
     }
     if (err == TransactionError::EXTERNAL_SIGNER_NOT_FOUND) {
         //: "External signer" means using devices such as hardware wallets.
-        QMessageBox::critical(nullptr, tr("External signer not found"), "External signer not found");
+        const QString msg = tr("External signer not found");
+        QMessageBox::critical(nullptr, msg, msg);
         return false;
     }
     if (err == TransactionError::EXTERNAL_SIGNER_FAILED) {
         //: "External signer" means using devices such as hardware wallets.
-        QMessageBox::critical(nullptr, tr("External signer failure"), "External signer failure");
+        const QString msg = tr("External signer failure");
+        QMessageBox::critical(nullptr, msg, msg);
         return false;
     }
     if (err != TransactionError::OK) {

Original file line number	Diff line number	Diff line change
`@@ -454,12 +454,14 @@ bool SendCoinsDialog::signWithExternalSigner(PartiallySignedTransaction& psbtx,`
`454`	`454`	`}`
`455`	`455`	`if (err == TransactionError::EXTERNAL_SIGNER_NOT_FOUND) {`
`456`	`456`	`//: "External signer" means using devices such as hardware wallets.`
`457`		`- QMessageBox::critical(nullptr, tr("External signer not found"), "External signer not found");`
	`457`	`+ const QString msg = tr("External signer not found");`
	`458`	`+ QMessageBox::critical(nullptr, msg, msg);`
`458`	`459`	`return false;`
`459`	`460`	`}`
`460`	`461`	`if (err == TransactionError::EXTERNAL_SIGNER_FAILED) {`
`461`	`462`	`//: "External signer" means using devices such as hardware wallets.`
`462`		`- QMessageBox::critical(nullptr, tr("External signer failure"), "External signer failure");`
	`463`	`+ const QString msg = tr("External signer failure");`
	`464`	`+ QMessageBox::critical(nullptr, msg, msg);`
`463`	`465`	`return false;`
`464`	`466`	`}`
`465`	`467`	`if (err != TransactionError::OK) {`