Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly

luke-jr · hebasto · commit 08b8b287d376 · 2023-03-31T12:21:51.000+01:00
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -984,10 +984,11 @@ void RPCConsole::setMempoolSize(long numberOfTxs, size_t dynUsage)
 {
     ui->mempoolNumberTxs->setText(QString::number(numberOfTxs));
 
-    if (dynUsage < 1000000)
-        ui->mempoolSize->setText(QString::number(dynUsage/1000.0, 'f', 2) + " KB");
-    else
-        ui->mempoolSize->setText(QString::number(dynUsage/1000000.0, 'f', 2) + " MB");
+    if (dynUsage < 1000000) {
+        ui->mempoolSize->setText(QObject::tr("%1 kB").arg(dynUsage / 1000.0, 0, 'f', 2));
+    } else {
+        ui->mempoolSize->setText(QObject::tr("%1 MB").arg(dynUsage / 1000000.0, 0, 'f', 2));
+    }
 }
 
 void RPCConsole::on_lineEdit_returnPressed()

Original file line number	Diff line number	Diff line change
`@@ -984,10 +984,11 @@ void RPCConsole::setMempoolSize(long numberOfTxs, size_t dynUsage)`
`984`	`984`	`{`
`985`	`985`	`ui->mempoolNumberTxs->setText(QString::number(numberOfTxs));`
`986`	`986`
`987`		`- if (dynUsage < 1000000)`
`988`		`- ui->mempoolSize->setText(QString::number(dynUsage/1000.0, 'f', 2) + " KB");`
`989`		`- else`
`990`		`- ui->mempoolSize->setText(QString::number(dynUsage/1000000.0, 'f', 2) + " MB");`
	`987`	`+ if (dynUsage < 1000000) {`
	`988`	`+ ui->mempoolSize->setText(QObject::tr("%1 kB").arg(dynUsage / 1000.0, 0, 'f', 2));`
	`989`	`+ } else {`
	`990`	`+ ui->mempoolSize->setText(QObject::tr("%1 MB").arg(dynUsage / 1000000.0, 0, 'f', 2));`
	`991`	`+ }`
`991`	`992`	`}`
`992`	`993`
`993`	`994`	`void RPCConsole::on_lineEdit_returnPressed()`