Merge #123: Sync with the main repo

Pull request description:

  Sync with the main repo up to the latest bitcoin/bitcoin@ba48fcf.

  No conflicts :)

  #### Guix builds:
  ```
  $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
  5f75bc511ddab20776638db8540232ae584b21d605635e4bb50fcc25d5d3195a  guix-build-8f7ae495c14e/output/aarch64-linux-gnu/SHA256SUMS.part
  741a598f854968fee09f800ff523885dca9c3191da8eb12ae50ea92db63851d8  guix-build-8f7ae495c14e/output/aarch64-linux-gnu/bitcoin-8f7ae495c14e-aarch64-linux-gnu-debug.tar.gz
  f02d43decb0ff440e6b9b5b3c9c3f30f5504443e572f43258e97be89763f6afa  guix-build-8f7ae495c14e/output/aarch64-linux-gnu/bitcoin-8f7ae495c14e-aarch64-linux-gnu.tar.gz
  ef60c50778b7c0988723690e043562f3ff9b8ac4d5bd18d09ad8b1d3ac7b5489  guix-build-8f7ae495c14e/output/arm-linux-gnueabihf/SHA256SUMS.part
  a5503b5f2485a0762ecec8eea2367a16e7f9dd76ae9bbfd76f5988551ee0c43a  guix-build-8f7ae495c14e/output/arm-linux-gnueabihf/bitcoin-8f7ae495c14e-arm-linux-gnueabihf-debug.tar.gz
  eb79bc04cdc155a8fa8b826c8d16d45986f4bfba0f7602e348851769710a6fa2  guix-build-8f7ae495c14e/output/arm-linux-gnueabihf/bitcoin-8f7ae495c14e-arm-linux-gnueabihf.tar.gz
  fc9a2232d67df73a24a3eb7792b9c61ba512346ca490bffda898a9a807638345  guix-build-8f7ae495c14e/output/arm64-apple-darwin/SHA256SUMS.part
  9646f609e59439aec9db0fc225a5528adb9b60212d63673537034de42b2f52fd  guix-build-8f7ae495c14e/output/arm64-apple-darwin/bitcoin-8f7ae495c14e-arm64-apple-darwin-unsigned.dmg
  9088b3babdc3846c226cc2061b04d3103aaaabe91525e9141de1b5346b309c6a  guix-build-8f7ae495c14e/output/arm64-apple-darwin/bitcoin-8f7ae495c14e-arm64-apple-darwin-unsigned.tar.gz
  5a7f6fb5d1fbc9f337071ed7f60f4fda7ff3bd6768d396c75313e97b3be17995  guix-build-8f7ae495c14e/output/arm64-apple-darwin/bitcoin-8f7ae495c14e-arm64-apple-darwin.tar.gz
  2a0241676b251b91afbe5b6a6f6f52f9592635ff73194246b338ca0faabb8316  guix-build-8f7ae495c14e/output/dist-archive/bitcoin-8f7ae495c14e.tar.gz
  bc74a4de28a852292766a6eb446589e3947afdf5fb392ca0cd56b4b736619f07  guix-build-8f7ae495c14e/output/powerpc64-linux-gnu/SHA256SUMS.part
  404ddc865d86f7f5d202950927d26727e055c69a5817f70fb37eb2a7f00f6cdf  guix-build-8f7ae495c14e/output/powerpc64-linux-gnu/bitcoin-8f7ae495c14e-powerpc64-linux-gnu-debug.tar.gz
  40ab9d0dad720b18eb5a1d4e8e9c5e5a7ce79f0cc086684f717a7779855c34cd  guix-build-8f7ae495c14e/output/powerpc64-linux-gnu/bitcoin-8f7ae495c14e-powerpc64-linux-gnu.tar.gz
  155f215a63e34dc46e7992e3e7e6b632432a4fcd7791c2f6c03b905ebd3ad610  guix-build-8f7ae495c14e/output/powerpc64le-linux-gnu/SHA256SUMS.part
  07ed3c6dc4701cd13513907b9cb7af7f99ae7e42a302a38d31acccc6cd595ea8  guix-build-8f7ae495c14e/output/powerpc64le-linux-gnu/bitcoin-8f7ae495c14e-powerpc64le-linux-gnu-debug.tar.gz
  c14ad68c026f30f9a789bb60e9a1d338c31e14dfd65f2dba95ccaa563c9671d7  guix-build-8f7ae495c14e/output/powerpc64le-linux-gnu/bitcoin-8f7ae495c14e-powerpc64le-linux-gnu.tar.gz
  89f87547e6f9e7c94ef27eb469e79d437fbfc381df6da3752cd28349a35ca996  guix-build-8f7ae495c14e/output/riscv64-linux-gnu/SHA256SUMS.part
  63713ba89afccb2c99f6519ad110eb68a053dbf800215e4eabf0aa3415d49b60  guix-build-8f7ae495c14e/output/riscv64-linux-gnu/bitcoin-8f7ae495c14e-riscv64-linux-gnu-debug.tar.gz
  782c4cda9bbf8acec213b3ce3e98f402ca1d991a8883b58793b2a3e98128b1bd  guix-build-8f7ae495c14e/output/riscv64-linux-gnu/bitcoin-8f7ae495c14e-riscv64-linux-gnu.tar.gz
  5e5e60c56055ebc79c76b5a77cae167328e1e198bb15b5e8ef70e2ce5f3a602c  guix-build-8f7ae495c14e/output/x86_64-apple-darwin/SHA256SUMS.part
  1e5996024194bec36ce39dce74530fd3ac50ff5ec6be5c5278273201fc568b88  guix-build-8f7ae495c14e/output/x86_64-apple-darwin/bitcoin-8f7ae495c14e-x86_64-apple-darwin-unsigned.dmg
  e2936d470aad785e200c8fbe36f9a7cdd22aaf49fa601f693b6a6e30d757ddb3  guix-build-8f7ae495c14e/output/x86_64-apple-darwin/bitcoin-8f7ae495c14e-x86_64-apple-darwin-unsigned.tar.gz
  7a47c67c2a7a4e809bd5c9b8141d4c381b4581a6e8f0a742325be3734b666ad9  guix-build-8f7ae495c14e/output/x86_64-apple-darwin/bitcoin-8f7ae495c14e-x86_64-apple-darwin.tar.gz
  e5caa7325c32a36f728b095bd915adf84a72ddee5fb0727f22d175460dd8fca4  guix-build-8f7ae495c14e/output/x86_64-linux-gnu/SHA256SUMS.part
  c44e56a7d43022dbca55cc6d34c5a5ad8f901f260808b067a8111dd97f4059f1  guix-build-8f7ae495c14e/output/x86_64-linux-gnu/bitcoin-8f7ae495c14e-x86_64-linux-gnu-debug.tar.gz
  e812a31c799212af01b9d1d92b5083ffcece41b773596ebc1bf28000a4234280  guix-build-8f7ae495c14e/output/x86_64-linux-gnu/bitcoin-8f7ae495c14e-x86_64-linux-gnu.tar.gz
  a4160656eb3cda09b9176e6fe2ce383d09874156a6777bbd9866d66d1197b734  guix-build-8f7ae495c14e/output/x86_64-w64-mingw32/SHA256SUMS.part
  b6e4c886cddd270dd1bb891ae9ec4b80e8b4de2e99d48405760710989a36c1ef  guix-build-8f7ae495c14e/output/x86_64-w64-mingw32/bitcoin-8f7ae495c14e-win64-debug.zip
  680b95435b421071dbe87d2eacd9e2992dd34fe21843c7a1894197110146bde0  guix-build-8f7ae495c14e/output/x86_64-w64-mingw32/bitcoin-8f7ae495c14e-win64-setup-unsigned.exe
  b89cfcdadb03afd75554d43649187a8d86dc32061501a4141a23ac2da90ee323  guix-build-8f7ae495c14e/output/x86_64-w64-mingw32/bitcoin-8f7ae495c14e-win64-unsigned.tar.gz
  780fda0104eedc78276e718ce0fade364c9377eb88c38842b41d81d402f5df31  guix-build-8f7ae495c14e/output/x86_64-w64-mingw32/bitcoin-8f7ae495c14e-win64.zip
  ```

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/123)
  [![macOS](https://img.shields.io/badge/OS-macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/123)
  [![Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/123)

ACKs for top commit:
  jarolrod:
    ACK 8f7ae49

Tree-SHA512: b9de17e9ce38d9c226737351d48291187a0d3bec7f233a65ea4baacde9bdb259a39bf82bd35944eec914aac354eef3e8af6efa19002a7c3ee0d6063b48c13edd

Author: hebasto

.gitignore

@@ -77,7 +77,6 @@ src/qt/bitcoin-qt.includes
 *.log
 *.trs
 *.dmg
-*.iso
 
 *.json.h
 *.raw.h

CONTRIBUTING.md

@@ -10,10 +10,9 @@ First, in terms of structure, there is no particular concept of "Bitcoin Core
 developers" in the sense of privileged people. Open source often naturally
 revolves around a meritocracy where contributors earn trust from the developer
 community over time. Nevertheless, some hierarchy is necessary for practical
-purposes. As such, there are repository "maintainers" who are responsible for
-merging pull requests, as well as a "lead maintainer" who is responsible for the
-[release cycle](/doc/release-process.md) as well as overall merging, moderation
-and appointment of maintainers.
+purposes. As such, there are repository maintainers who are responsible for
+merging pull requests, the [release cycle](/doc/release-process.md), and
+moderation.
 
 Getting Started
 ---------------
@@ -293,7 +292,7 @@ projects such as libsecp256k1), and is not to be confused with overall Bitcoin
 Network Protocol consensus changes.
 
 Whether a pull request is merged into Bitcoin Core rests with the project merge
-maintainers and ultimately the project lead.
+maintainers.
 
 Maintainers will take into consideration if a patch is in line with the general
 principles of the project; meets the minimum standards for inclusion; and will

Makefile.am

@@ -12,7 +12,7 @@ if ENABLE_MAN
 SUBDIRS += doc/man
 endif
 .PHONY: deploy FORCE
-.INTERMEDIATE: $(OSX_TEMP_ISO) $(COVERAGE_INFO)
+.INTERMEDIATE: $(COVERAGE_INFO)
 
 export PYTHONPATH
 
@@ -37,7 +37,6 @@ space := $(empty) $(empty)
 OSX_APP=Bitcoin-Qt.app
 OSX_VOLNAME = $(subst $(space),-,$(PACKAGE_NAME))
 OSX_DMG = $(OSX_VOLNAME).dmg
-OSX_TEMP_ISO = $(OSX_DMG:.dmg=).temp.iso
 OSX_DEPLOY_SCRIPT=$(top_srcdir)/contrib/macdeploy/macdeployqtplus
 OSX_INSTALLER_ICONS=$(top_srcdir)/src/qt/res/icons/bitcoin.icns
 OSX_PLIST=$(top_builddir)/share/qt/Info.plist #not installed
@@ -130,19 +129,15 @@ deploydir: $(OSX_DMG)
 else !BUILD_DARWIN
 APP_DIST_DIR=$(top_builddir)/dist
 
-$(OSX_TEMP_ISO): $(APP_DIST_DIR)/$(OSX_APP)/Contents/MacOS/Bitcoin-Qt
+$(OSX_DMG): deploydir
 	$(XORRISOFS) -D -l -V "$(OSX_VOLNAME)" -no-pad -r -dir-mode 0755 -o $@ $(APP_DIST_DIR) -- $(if $(SOURCE_DATE_EPOCH),-volume_date all_file_dates =$(SOURCE_DATE_EPOCH))
 
-$(OSX_DMG): $(OSX_TEMP_ISO)
-	$(DMG) dmg "$<" "$@"
-
 $(APP_DIST_DIR)/$(OSX_APP)/Contents/MacOS/Bitcoin-Qt: $(OSX_APP_BUILT) $(OSX_PACKAGING)
-	INSTALLNAMETOOL=$(INSTALLNAMETOOL) OTOOL=$(OTOOL) STRIP=$(STRIP) $(PYTHON) $(OSX_DEPLOY_SCRIPT) $(OSX_APP) $(OSX_VOLNAME) -translations-dir=$(QT_TRANSLATION_DIR)
+	INSTALL_NAME_TOOL=$(INSTALL_NAME_TOOL) OTOOL=$(OTOOL) STRIP=$(STRIP) $(PYTHON) $(OSX_DEPLOY_SCRIPT) $(OSX_APP) $(OSX_VOLNAME) -translations-dir=$(QT_TRANSLATION_DIR)
 
 deploydir: $(APP_DIST_DIR)/$(OSX_APP)/Contents/MacOS/Bitcoin-Qt
 endif !BUILD_DARWIN
 
-appbundle: $(OSX_APP_BUILT)
 deploy: $(OSX_DMG)
 endif
 

README.md

@@ -6,18 +6,14 @@ https://bitcoincore.org
 For an immediately usable, binary version of the Bitcoin Core software, see
 https://bitcoincore.org/en/download/.
 
-Further information about Bitcoin Core is available in the [doc folder](/doc).
-
-What is Bitcoin?
-----------------
+What is Bitcoin Core?
+---------------------
 
-Bitcoin is an experimental digital currency that enables instant payments to
-anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate
-with no central authority: managing transactions and issuing money are carried
-out collectively by the network. Bitcoin Core is the name of open source
-software which enables the use of this currency.
+Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully
+validate blocks and transactions. It also includes a wallet and graphical user
+interface, which can be optionally built.
 
-For more information read the original Bitcoin whitepaper.
+Further information about Bitcoin Core is available in the [doc folder](/doc).
 
 License
 -------

REVIEWERS

@@ -112,7 +112,7 @@
 /src/dbwrapper.*                            @jamesob
 
 # Linter
-/test/lint/lint-shell.sh                    @hebasto
+/test/lint/lint-shell.py                    @hebasto
 
 # Bech32
 /src/bech32.*                               @sipa

ci/lint/06_script.sh

@@ -22,7 +22,7 @@ test/lint/git-subtree-check.sh src/univalue
 test/lint/git-subtree-check.sh src/leveldb
 test/lint/git-subtree-check.sh src/crc32c
 test/lint/check-doc.py
-test/lint/lint-all.sh
+test/lint/lint-all.py
 
 if [ "$CIRRUS_REPO_FULL_NAME" = "bitcoin/bitcoin" ] && [ "$CIRRUS_PR" = "" ] ; then
     # Sanity check only the last few commits to get notified of missing sigs,

ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh

@@ -11,4 +11,4 @@ export DOCKER_NAME_TAG=ubuntu:18.04  # Use bionic to have one config run the tes
 export PACKAGES="python3-zmq clang-8 llvm-8 libc++abi-8-dev libc++-8-dev"  # Use clang-8 to test C++17 compatibility, see doc/dependencies.md
 export DEP_OPTS="NO_WALLET=1 CC=clang-8 CXX='clang++-8 -stdlib=libc++'"
 export GOAL="install"
-export BITCOIN_CONFIG="--enable-reduce-exports CC=clang-8 CXX='clang++-8 -stdlib=libc++' --enable-experimental-util-chainstate"
+export BITCOIN_CONFIG="--enable-reduce-exports CC=clang-8 CXX='clang++-8 -stdlib=libc++' --enable-experimental-util-chainstate --with-experimental-kernel-lib --enable-shared"

ci/test/00_setup_env_native_qt5.sh

@@ -14,6 +14,6 @@ export TEST_RUNNER_EXTRA="--previous-releases --coverage --extended --exclude fe
 export RUN_UNIT_TESTS_SEQUENTIAL="true"
 export RUN_UNIT_TESTS="false"
 export GOAL="install"
-export PREVIOUS_RELEASES_TO_DOWNLOAD="v0.14.3 v0.15.2 v0.16.3 v0.17.2 v0.18.1 v0.19.1 v0.20.1 v0.21.0 v22.0"
+export PREVIOUS_RELEASES_TO_DOWNLOAD="v0.14.3 v0.15.2 v0.16.3 v0.17.2 v0.18.1 v0.19.1 v0.20.1 v0.21.0 v22.0 v23.0"
 export BITCOIN_CONFIG="--enable-zmq --with-libs=no --with-gui=qt5 --enable-reduce-exports \
 --enable-debug CFLAGS=\"-g0 -O2 -funsigned-char\" CXXFLAGS=\"-g0 -O2 -funsigned-char\" CC=gcc-9 CXX=g++-9"

ci/test/00_setup_env_native_tidy.sh

@@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8
 
 export DOCKER_NAME_TAG="ubuntu:22.04"
 export CONTAINER_NAME=ci_native_tidy
-export PACKAGES="clang llvm clang-tidy bear libevent-dev libboost-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev systemtap-sdt-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libqrencode-dev libsqlite3-dev libdb++-dev"
+export PACKAGES="clang libclang-dev llvm-dev clang-tidy bear cmake libevent-dev libboost-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev systemtap-sdt-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libqrencode-dev libsqlite3-dev libdb++-dev"
 export NO_DEPENDS=1
 export RUN_UNIT_TESTS=false
 export RUN_FUNCTIONAL_TESTS=false

ci/test/00_setup_env_native_tsan.sh

@@ -11,4 +11,4 @@ export DOCKER_NAME_TAG=ubuntu:22.04
 export PACKAGES="clang-13 llvm-13 libc++abi-13-dev libc++-13-dev python3-zmq"
 export DEP_OPTS="CC=clang-13 CXX='clang++-13 -stdlib=libc++'"
 export GOAL="install"
-export BITCOIN_CONFIG="--enable-zmq CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER' CXXFLAGS='-g' --with-sanitizers=thread CC=clang-13 CXX='clang++-13 -stdlib=libc++'"
+export BITCOIN_CONFIG="--enable-zmq CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER -DDEBUG_LOCKCONTENTION' CXXFLAGS='-g' --with-sanitizers=thread CC=clang-13 CXX='clang++-13 -stdlib=libc++'"