Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Decouple Twig from Adroit #8

Closed
shochdoerfer opened this issue Nov 21, 2015 · 5 comments
Closed

Decouple Twig from Adroit #8

shochdoerfer opened this issue Nov 21, 2015 · 5 comments
Milestone

Comments

@shochdoerfer
Copy link
Member

It might be worthwhile to decouple Twig from Adroit and create an separate adroit-twig package just for the TwigResponder.

@geekishmatt
Copy link

I'd suggest to decouple them. The TwigResponder bloats up the framework and is just another unnecessary dependency. From my point of view the JsonResponder should be enough.

@msphn
Copy link

msphn commented Nov 23, 2015

Decouple but don't delete it. I'm using it.

@geekishmatt
Copy link

@cookiekiller What about a adroit-twig package (I'd suggest to call it bitexpert/twigastic)?
@shochdoerfer Was there any decision made?

@shochdoerfer
Copy link
Member Author

I would love to do it but I am not sure if right now is a good time to do it as we haven`t gained much experience to understand if the Responder interface makes sense. I do not want to constantly change the interface and change the dependant packages as well. That would be way too much effort.

Ideally we would be able to find an agreement with @pmjones (and others) on a standard interface for actions, responders and the domain payload object to drive forward the collaboration between the different ADR implementations.

@dropdevcoding dropdevcoding added this to the 0.4.0 milestone May 13, 2016
@dropdevcoding
Copy link
Contributor

Twig integration has been moved to bitexpert/adrenaline where it will possibly become a separate package in near future (to discuss).

For Adroit this one is closed by #23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants