From acb99ecb0c9f46291c90b406652db122584b7891 Mon Sep 17 00:00:00 2001 From: Jonas Gorski Date: Fri, 14 Oct 2022 10:02:21 +0200 Subject: [PATCH 1/2] drop experimental from KNET interfaces These now work stable, so we don't need to mark them as experimental anymore. Signed-off-by: Jonas Gorski --- pkg/systemd/sysconfig.template | 2 +- src/baseboxd.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/systemd/sysconfig.template b/pkg/systemd/sysconfig.template index fbc1e4eb..246dd9e8 100644 --- a/pkg/systemd/sysconfig.template +++ b/pkg/systemd/sysconfig.template @@ -9,7 +9,7 @@ # gRPC listening port: # FLAGS_ofdpa_grpc_port=50051 # -# Use KNET interfaces (experimental): +# Use KNET interfaces: # FLAGS_use_knet=false ### glog diff --git a/src/baseboxd.cc b/src/baseboxd.cc index 33aad7bd..5e13bba4 100644 --- a/src/baseboxd.cc +++ b/src/baseboxd.cc @@ -19,7 +19,7 @@ DECLARE_string(tryfromenv); // from gflags DEFINE_bool(multicast, true, "Enable multicast support"); DEFINE_int32(port, 6653, "Listening port"); DEFINE_int32(ofdpa_grpc_port, 50051, "Listening port of ofdpa gRPC server"); -DEFINE_bool(use_knet, false, "Use KNET interfaces (experimental)"); +DEFINE_bool(use_knet, false, "Use KNET interfaces"); static bool validate_port(const char *flagname, gflags::int32 value) { VLOG(3) << __FUNCTION__ << ": flagname=" << flagname << ", value=" << value; From 1795920b36fd48e97553ca27885d56a08cd341eb Mon Sep 17 00:00:00 2001 From: Jonas Gorski Date: Fri, 14 Oct 2022 10:04:33 +0200 Subject: [PATCH 2/2] enable KNET interfaces by default KNET interfaces on switch work stable, and offer more throughput and lower latency, and avoid the issue of traffic to/from controller overloading the OpenFlow connection. So switch to them as default. Signed-off-by: Jonas Gorski --- pkg/systemd/sysconfig.template | 2 +- src/baseboxd.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/systemd/sysconfig.template b/pkg/systemd/sysconfig.template index 246dd9e8..2d10033f 100644 --- a/pkg/systemd/sysconfig.template +++ b/pkg/systemd/sysconfig.template @@ -10,7 +10,7 @@ # FLAGS_ofdpa_grpc_port=50051 # # Use KNET interfaces: -# FLAGS_use_knet=false +# FLAGS_use_knet=true ### glog # diff --git a/src/baseboxd.cc b/src/baseboxd.cc index 5e13bba4..17df3c36 100644 --- a/src/baseboxd.cc +++ b/src/baseboxd.cc @@ -19,7 +19,7 @@ DECLARE_string(tryfromenv); // from gflags DEFINE_bool(multicast, true, "Enable multicast support"); DEFINE_int32(port, 6653, "Listening port"); DEFINE_int32(ofdpa_grpc_port, 50051, "Listening port of ofdpa gRPC server"); -DEFINE_bool(use_knet, false, "Use KNET interfaces"); +DEFINE_bool(use_knet, true, "Use KNET interfaces"); static bool validate_port(const char *flagname, gflags::int32 value) { VLOG(3) << __FUNCTION__ << ": flagname=" << flagname << ", value=" << value;