Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc tweaks #4

Open
davidknoll opened this issue Jul 15, 2020 · 0 comments
Open

Misc tweaks #4

davidknoll opened this issue Jul 15, 2020 · 0 comments

Comments

@davidknoll
Copy link

I started using this a while ago at work, and wondered if you would be interested in any of this commit. I haven't done a PR, because I made other local changes at the time and there is a caveat about logging.

  • I added a MONGODB_QUIET option, on seeing how much log output the progress reporting generates when running under GKE, but then didn't actually use it.
  • Changing the .tar.gz extension of the output archives, as it's not a tarball, it's actually a binary format specific to mongodump.
    • In fact even the version of the mongo tools affects it- eg dumps taken using the mongo 4.2 tools inside the 0.2.0 docker image, in my testing were not understood by a 4.0 mongorestore even though the backup was taken from a 4.0 server.
  • Keep the log output as it goes (using tee), and in the event of an error, emit the last line of that on Slack. I had noticed that the errors outputted to Slack otherwise amounted to "something went wrong", but gave me little idea what went wrong.
    • The caveat of what I did here, is that the 2>&1 where I pipe the output to tee, also means the logs aren't differentiated between stdout/stderr when output to the console, and therefore aren't differentiated between info/error in my GKE logs.
  • I needed to put quotes on something in the helm yaml to get it to deploy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant